Closed
Bug 1335246
Opened 8 years ago
Closed 8 years ago
Mozreview uses a different file sort order in its review UI, as compared to its issues UI and its generated Bugzilla comments (so it reshuffles order of my review feedback)
Categories
(MozReview Graveyard :: General, defect, P2)
MozReview Graveyard
General
Tracking
(Not tracked)
VERIFIED
WORKSFORME
People
(Reporter: dholbert, Unassigned)
Details
Attachments
(2 files)
STR:
Compare the ordering of files here (the view I saw when reviewing)...
https://reviewboard.mozilla.org/r/108338/diff/5#index_header
...to the file ordering that it used when generating a bugzilla comment for my review:
https://bugzilla.mozilla.org/show_bug.cgi?id=1166147#c42
ACTUAL RESULTS:
- In the review UI, MozReview lists "1166147.html" before "1166147-ref.html".
- In the generated bugzilla comment (and in the issues list in MozReview), MozReview uses the opposite order -- it shows my feedback on the -ref.html file *first*.
This caused some trouble because I happened to refer back to one of my earlier comments from another one, but when MozReview produced the bugzilla comment, the ordering was swapped, so my reference made no sense. (Note that bug 1166147 comment 42 starts with "Similarly" -- that's referring to a comment that MozReview shifted later in that bug comment.)
EXPECTED RESULTS:
- MozReview should use a consistent file sorting order. (foo.html should consistently sort either before or after foo-ref.html, throughout MozReview.)
- Put another way: comments that I leave "higher up" in a review should appear "higher up" on the issues list & in the generated bugzilla comment.
Reporter | ||
Updated•8 years ago
|
Summary: Mozreview uses a different file sort order, in its review UI, as compared to its issues UI and its generated Bugzilla comments → Mozreview uses a different file sort order in its review UI, as compared to its issues UI and its generated Bugzilla comments (so it reshuffles order of my review feedback)
Reporter | ||
Comment 1•8 years ago
|
||
Reporter | ||
Comment 2•8 years ago
|
||
Updated•8 years ago
|
Priority: -- → P2
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
Reporter | ||
Comment 3•8 years ago
|
||
Verified WFM.
(In reply to Daniel Holbert [:dholbert] from comment #0)
> ACTUAL RESULTS:
> - In the review UI, MozReview lists "1166147.html" before "1166147-ref.html".
(Now, it lists 1166147-ref.html first.)
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•