Closed
Bug 1335658
Opened 8 years ago
Closed 8 years ago
Crash when Render Thread is enabled when GPU process exists
Categories
(Core :: Graphics: WebRender, defect)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla54
People
(Reporter: sotaro, Assigned: sotaro)
References
Details
Attachments
(1 file)
(deleted),
patch
|
nical
:
review+
kats
:
review+
|
Details | Diff | Splinter Review |
With the following change, we could enable render thread.
> #define MOZ_USE_RENDER_THREAD true
When GPU process exists, render thread was not started in the GPU process. It caused a crash.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → sotaro.ikeda.g
Assignee | ||
Comment 1•8 years ago
|
||
FYI: diagram around GPU process.
https://github.com/sotaroikeda/firefox-diagrams/blob/master/gfx/gfx_GPUProcessManager_53.pdf
Assignee | ||
Comment 2•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Attachment #8832348 -
Flags: review?(nical.bugzilla)
Comment 3•8 years ago
|
||
Comment on attachment 8832348 [details] [diff] [review]
patch - Init RenderThread in GPUParent
Review of attachment 8832348 [details] [diff] [review]:
-----------------------------------------------------------------
FWIW the patch looks good to me.
Attachment #8832348 -
Flags: review+
Updated•8 years ago
|
Attachment #8832348 -
Flags: review?(nical.bugzilla) → review+
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/fca2fcdfbc9f
Init RenderThread in GPUParent r=nical,kats
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•