Now that we support processing STYLE_ATTRIBUTE restyle hints on the Servo side, we can pass through eRestyle_StyleAttribute to Servo_NoteExplicitHints without converting it to eRestyle_Self/Subtree.

Comment on attachment 8835942 [details] Align RESTYLE_STYLE_ATTRIBUTE value with eRestyle_StyleAttribute. https://reviewboard.mozilla.org/r/111492/#review112930 ::: servo/components/style/restyle_hints.rs:49 (Diff revision 1) > const RESTYLE_LATER_SIBLINGS = 0x08, > > /// Don't re-run selector-matching on the element, only the style > /// attribute has changed, and this change didn't have any other > /// dependencies. > - const RESTYLE_STYLE_ATTRIBUTE = 0x10, > + const RESTYLE_STYLE_ATTRIBUTE = 0x80, So, this makes me a bit nervous. Please add a comment above RestyleHint that the bit positions matter for gecko compat. I think we should also add some static assertions in RestyleHint::from below that: (1) Each RestyleHint corresponds to the appropriate value according to bindgen, and that: (2) The union of all the bits we check is equal to RestyleHint::all() (to prevent unintentionally allowing garbage bits from Gecko if somebody adds a new restle hint).

Comment on attachment 8835943 [details] Bug 1338461 - Pass eRestyle_StyleAttribute through to Servo_NoteExplicitHints. https://reviewboard.mozilla.org/r/111494/#review112932

> I think we should also add some static assertions in RestyleHint::from below > that: > (1) Each RestyleHint corresponds to the appropriate value according to > bindgen, and that: > (2) The union of all the bits we check is equal to RestyleHint::all() (to > prevent unintentionally allowing garbage bits from Gecko if somebody adds a > new restle hint). I found existing assertions in tests/unit/stylo/sanity_checks.rs so I will add them there and point to them from the comment.

(In reply to Cameron McCormack (:heycam) from comment #6) > > I think we should also add some static assertions in RestyleHint::from below > > that: > > (1) Each RestyleHint corresponds to the appropriate value according to > > bindgen, and that: > > (2) The union of all the bits we check is equal to RestyleHint::all() (to > > prevent unintentionally allowing garbage bits from Gecko if somebody adds a > > new restle hint). > > I found existing assertions in tests/unit/stylo/sanity_checks.rs so I will > add them there and point to them from the comment. Would you mind moving those to restyle_hints.rs? In the current world those unit tests will run against the checked-in bindings, which may be arbitrarily out of date. I think it's much better to catch these bugs as soon as the enum on either side is changed.

OK, moving those in https://github.com/servo/servo/pull/15538.

Interestingly, I get some test failures from this: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9105655834fc

Pushed by cmccormack@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1ac14d8a4ca4 Pass eRestyle_StyleAttribute through to Servo_NoteExplicitHints. r=bholley