Closed Bug 1343301 Opened 8 years ago Closed 8 years ago

disable non-e10s Stylo tests because we will disable all non-e10s tests in 57

Categories

(Firefox Build System :: Task Configuration, task)

Product:
Firefox Build System
Component:
Task Configuration
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla55

People

(Reporter: kmoir, Assigned: kmoir)

References

Details

Attachments

(1 file, 3 obsolete files)

bug1343301-all.patch
(deleted), patch
Details | Diff | Splinter Review
from today's quantum meeting -> jmaher advised to turn off non-e10s Stylo tests because we will disable all non-e10s tests in 57
Assignee: nobody → kmoir
Attached patch bug1343301.patch (obsolete) (deleted) — — Splinter Review
Attached patch bug1343301.patch (obsolete) (deleted) — — Splinter Review
Attachment #8842123 - Attachment is obsolete: true
Attachment #8843358 - Flags: review?(dustin)
Attachment #8843358 - Flags: review?(dustin) → review+
Pushed by kmoir@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/fb3bfd49e641 disable non-e10s Stylo tests because we will disable all non-e10s tests in 57 r=dustin DONTBUILD
Pushed by kmoir@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c9b87d42837f revert Bug 1343301 - disable non-e10s Stylo tests because we will disable all non-e10s tests in 57 r=dustin DONTBUILD
That didn't work, it disabled all the reftests for stylo, including e10s. Not sure why, investigating. In the interim I have reverted the patch.
Pushed by kmoir@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/7d7f4f3e5fde disable non-e10s Stylo tests because we will disable all non-e10s tests in 57 r=me
Attached patch bug1343301-2.patch (obsolete) (deleted) — — Splinter Review
Trying this patch now. Difficult to test on try.
Pushed by kmoir@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/1574d9c42753 disable non-e10s Stylo tests because we will disable all non-e10s tests in 57 r=me
Attached patch bug1343301-all.patch (deleted) — — Splinter Review
This fixed the issues on inbound, will see if it runs the correct set of tests on other branches as it is uplifted.
Attachment #8843358 - Attachment is obsolete: true
Attachment #8844005 - Attachment is obsolete: true
jmaher: does this requirement extend to turning off non-e10s tests that are not reftests?
Flags: needinfo?(jmaher)
talos will need to be shut off for non-e10s (well I think added for e10s only since it isn't defined yet), stylo reftests seem valuable in both non-e10s and e10s configurations. Are there specific concerns on a suite?
Flags: needinfo?(jmaher)
This was asked for in the Quantum developer productivity meeting last week jmaher suggests: we turn off non-e10s Stylo tests because we will disable all non-e10s tests in 57. reduce Talos frequency to once daily. https://docs.google.com/document/d/1AZI2tBjKGPvZ_ay2X6PQkwEML2PmhuWi12Vow1yWPN0/edit I'm working on enabling talos but haven't got it working yet.
Verified that only e10s reftests run on the branches specified. Will ask in quantum developer productivity meeting if non-e10s non-reftests should be disabled as well.
https://hg.mozilla.org/mozilla-central/rev/7d7f4f3e5fde https://hg.mozilla.org/mozilla-central/rev/1574d9c42753
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
reopening because I may need to disable more non-e10s non reftest tests, will ask in quantum meeting today
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
consensus was in meeting to leave other tests on so will close this bug
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED
Depends on: 1356122
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: