Right now the DOM panel doesn't have its id registered in telemetry.js http://searchfox.org/mozilla-central/source/devtools/client/shared/telemetry.js - so each time that panel is opened it results in a 'custom' tool opened event as a result of this: http://searchfox.org/mozilla-central/rev/4039fb4c5833706f6880763de216974e00ba096c/devtools/client/shared/telemetry.js#216 The solution is to follow the instructions in telemetry.js to add a new histogram.

Let me know how does this look! Tested it here https://treeherder.mozilla.org/#/jobs?repo=try&revision=f742c10f356eec50a3ae64a9d8ad351266f9a62b

Comment on attachment 8843897 [details] [diff] [review] bug-1343501.patch Review of attachment 8843897 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. @jryans: can you please look at this too? Honza

One more try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d1ac2484d920bead5ab21219afc2f0bd283d9c9f Honza

The try looks good, I think this is ready to land. Let's see Ryan's feedback yet. Honza

Comment on attachment 8843897 [details] [diff] [review] bug-1343501.patch Review of attachment 8843897 [details] [diff] [review]: ----------------------------------------------------------------- Looks reasonable to me on the DevTools side, but you may need one change as I've noted below. In addition, new telemetry probes require a review from the data collection group. Once you're ready, set feedback? to bsmedberg, as documented on the telemetry page[1]. [1]: https://developer.mozilla.org/en-US/docs/Mozilla/Performance/Adding_a_new_Telemetry_probe ::: toolkit/components/telemetry/Histograms.json @@ +7761,5 @@ > "releaseChannelCollection": "opt-out" > }, > + "DEVTOOLS_DOM_OPENED_COUNT": { > + "alert_emails": ["dev-developer-tools@lists.mozilla.org"], > + "expires_in_version": "never", I believe the Telemetry group no longer allows new probes with expires "never". I usually add ~10 to the current release, so you could put "65" here.

Argh, Bugzilla ate my comment! Thanks for the review and info links, jryans. I requested Benjamin's review as it seems a bit strange to me that we would track the usage of some panels without expiry and some others with it, and I couldn't find any mention to the allowed values for 'expires' in the documentation you linked. Not that I don't trust you, but I want to make sure we don't have to "renew" unnecessarily :-)

Comment on attachment 8843897 [details] [diff] [review] bug-1343501.patch Review of attachment 8843897 [details] [diff] [review]: ----------------------------------------------------------------- Looks good from my perspective, R+ Honza

I just realised Benjamin wants the *feedback* flag, not *review*. Benjamin, could you look and see if the proposed new probe looks fine? We want to track usage of a panel in DevTools, just as we are tracking for the other panels already. Thanks!

Bryan, for expires-never data collection we're looking for a commitment from somebody that you will actually be using the data permanently, or have it disabled if you're no longer using it. Are you the right person to make that commitment?

Yes, I use these probes to track panel usage. This one would go into my panels dashboard view https://sql.telemetry.mozilla.org/dashboard/-devtools-panels with the others.

Comment on attachment 8843897 [details] [diff] [review] bug-1343501.patch data-r=me

Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e939d2c1a8c1 Log telemetry for devtools DOM panel. r=Honza