Closed Bug 1350008 Opened 8 years ago Closed 8 years ago

Don't read the file type description from mimeTypes.rdf

Categories

(Firefox :: File Handling, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: Paolo, Assigned: Paolo)

References

Details

Attachments

(1 file)

In bug 1287664 we accidentally removed the last piece of code that was able to save file type descriptions in "mimeTypes.rdf". This does not have any practical effect, because there is no way in the browser to edit a file type description and make it different from the description provided by the operating system. The default implementation of nsIHandlerService still reads the description from "mimeTypes.rdf" if one is present. The data is only present for types saved before Firefox 52 or for types that are configured manually. I think we can safely remove the code that reads the legacy file type descriptions from "mimeTypes.rdf". All the consumers of nsIHandlerInfo are able to set up a default description when one is not available from the operating system or the configuration. The ability to edit "mimeTypes.rdf" manually to provide custom handler applications will continue to work, but file types unknown to the operating system will always get a default description. This allows us to simplify the JSON file format introduced in bug 1287660 before making it the default back-end in bug 1287658.
I don't think this behavior was tested anywhere, but let's see if there is any test code that depends on it: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f65b07b510bb7a966eecc4313eec6e41f0b20db2
Blocks: 1350026
Comment on attachment 8850609 [details] Bug 1350008 - Don't read the file type description from mimeTypes.rdf. https://reviewboard.mozilla.org/r/123150/#review128482 LGTM
Attachment #8850609 - Flags: review?(mak77) → review+
Pushed by paolo.mozmail@amadzone.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/847bbd6fa346 Don't read the file type description from mimeTypes.rdf. r=mak
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Assignee: nobody → paolo.mozmail
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: