Closed Bug 1351910 Opened 8 years ago Closed 8 years ago

Build more files as unified in ipc/glue

Categories

(Core :: IPC, defect)

Product:
Core
Component:
IPC
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: erahm, Assigned: erahm)

References

Details

Attachments

(1 file)

Build more files as unified in ipc/glue
(deleted), patch
billm
: review+
Details | Diff | Splinter Review
One file was excluded for using plarena which it did not. The other was excluded for "clashes with strdup," it does not use strdup. MozReview-Commit-ID: 5X5H9S4j903
Attachment #8852727 - Flags: review?(wmccloskey)
Comment on attachment 8852727 [details] [diff] [review] Build more files as unified in ipc/glue Review of attachment 8852727 [details] [diff] [review]: ----------------------------------------------------------------- Oddly, URIUtils.cpp didn't use strdup even when the original patch was checked in. But I guess it's easy to move this back if something goes wrong.
Attachment #8852727 - Flags: review?(wmccloskey) → review+
Backout by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f5dbc3ffb11f Backed out changeset 6933cdfb5186 for OSX bustage.
https://hg.mozilla.org/mozilla-central/rev/beac20cdb736
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: