This tracks all the bugs that need to be fixed before enabling shape-outside on Nightly and Aurora.

layout.css.shape-outside.enabled is the flag to flip here.

Comment on attachment 8969822 [details] Bug 1353631 Part 1: Set preference default to true in Nightly for layout.css.shape-outside.enabled. https://reviewboard.mozilla.org/r/238648/#review244406

Pushed by bwerth@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2dad6e7f5092 Set preference default to true in Nightly for layout.css.shape-outside.enabled. r=dholbert

Backed out changeset 2dad6e7f5092 (bug 1353631) for XPCShell failures on devtools/shared/tests/unit/test_css-properties-db.js Log of the fail: https://treeherder.mozilla.org/logviewer.html#?job_id=174898097&repo=autoland&lineNumber=7680 INFO - TEST-PASS | uriloader/exthandler/tests/unit/test_badMIMEType.js | took 588ms 20:13:03 INFO - TEST-START | uriloader/exthandler/tests/unit/test_handlerService.js 20:13:04 INFO - TEST-PASS | uriloader/exthandler/tests/unit/test_handlerService.js | took 719ms 20:13:04 INFO - TEST-START | uriloader/exthandler/tests/unit/test_handlerService_store.js 20:13:06 INFO - TEST-PASS | uriloader/exthandler/tests/unit/test_handlerService_store.js | took 1774ms 20:13:06 INFO - TEST-START | uriloader/exthandler/tests/unit/test_punycodeURIs.js 20:13:06 INFO - TEST-PASS | uriloader/exthandler/tests/unit/test_punycodeURIs.js | took 557ms 20:13:06 INFO - Retrying tests that failed when run in parallel. 20:13:06 INFO - TEST-START | devtools/shared/tests/unit/test_css-properties-db.js 20:13:07 WARNING - TEST-UNEXPECTED-FAIL | devtools/shared/tests/unit/test_css-properties-db.js | xpcshell return code: 0 20:13:07 INFO - TEST-INFO took 1092ms 20:13:07 INFO - >>>>>>> 20:13:07 INFO - PID 7109 | [7109, Main Thread] WARNING: Couldn't get the user appdata directory. Crash events may not be produced.: file /builds/worker/workspace/build/src/toolkit/crashreporter/nsExceptionHandler.cpp, line 2678 20:13:07 INFO - PID 7109 | JavaScript strict warning: resource://devtools/shared/Loader.jsm, line 224: ReferenceError: reference to undefined property "name" 20:13:07 INFO - (xpcshell/head.js) | test MAIN run_test pending (1) Backout: https://hg.mozilla.org/integration/autoland/rev/daaa0c840a9fb865971d59b4c5ba90d25f8cf42a Push with the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=2dad6e7f5092b3f52625bc339eb584f7d97163be

Looks like you need to run "./mach devtools-css-db" after applying this patch & building Firefox, and then amend the patch to include the generated changes (new entries for the pref-controlled properties in /devtools/shared/css/generated/properties-db.js )

(Or perhaps slightly better: capture that mach command's automated changes in a second patch in the series here -- to keep manual changes and automated changes separate.)

Comment on attachment 8970182 [details] Bug 1353631 Part 2: Regenerate devtools property database for properties protected by the pref. https://reviewboard.mozilla.org/r/238994/#review244662

Pushed by bwerth@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fd5bd538bfe7 Part 1: Set preference default to true in Nightly for layout.css.shape-outside.enabled. r=dholbert https://hg.mozilla.org/integration/autoland/rev/6a0c361f18ff Part 2: Regenerate devtools property database for properties protected by the pref. r=dholbert

Backed out for failing devtools/shared/tests/unit/test_css-properties-db.js Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=6a0c361f18ffb872dea686edcfd267a27584e918 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=175160794&repo=autoland&lineNumber=2497 Backout: https://hg.mozilla.org/integration/autoland/rev/ee56d8ed0ea8deb5fd5bcf502780c71ebe42c8d1

Failure text: ======== [task 2018-04-23T18:35:30.699Z] 18:35:30 WARNING - TEST-UNEXPECTED-FAIL | devtools/shared/tests/unit/test_css-properties-db.js | run_test - [run_test : 62] The static database and platform do not match for [task 2018-04-23T18:35:30.700Z] 18:35:30 INFO - "shape-margin". If this assertion fails, then the client side CSS properties list in devtools is out of sync with the CSS properties on the platform. To fix this assertion run `mach devtools-css-db` to re-generate the client side properties. - false == true ======== I think you did that in this latest push, so it's possible `mach devtools-css-db` has broken / isn't in sync with the test... Anyway: Brad, I suspect you can run the test locally and investigate further, like so: ./mach test devtools/shared/tests/unit/test_css-properties-db.js

Whoops, I had generated my css-db on top of a patch stack that ALSO defined shape-margin. This should be correct, now.

Hooray - I'm glad it's not something more subtle/annoying. :)

Pushed by bwerth@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/364395afa96f Part 1: Set preference default to true in Nightly for layout.css.shape-outside.enabled. r=dholbert https://hg.mozilla.org/integration/autoland/rev/d3d12129fe2f Part 2: Regenerate devtools property database for properties protected by the pref. r=dholbert

https://hg.mozilla.org/mozilla-central/rev/364395afa96f https://hg.mozilla.org/mozilla-central/rev/d3d12129fe2f

I've updated the entry about this property in our experimental features page: https://developer.mozilla.org/en-US/Firefox/Experimental_features#CSS We'll not mention it in the rel notes until it is enabled in release.