Closed Bug 1354730 Opened 8 years ago Closed 7 years ago

Disable named property object visibility on Xrays across the board once 57 ships

Categories

(Core :: XPConnect, enhancement, P2)

Product:
Core
Component:
XPConnect
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla58
Tracking Flags:
Tracking Status
firefox55 --- affected
firefox57 --- wontfix
firefox58 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

With some test fixes to the tests that were relying on the old behavior
(deleted), patch
kmag
: review+
Details | Diff | Splinter Review
Bug 1353150 is disabling it for webextensions. But we want to do this in general.
Flags: needinfo?(bzbarsky)
Depends on: 1353150
Blocks: post-57-api-changes
MozReview-Commit-ID: KmbXFfSzH0N
Attachment #8918447 - Flags: review?(kmaglione+bmo)
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Flags: needinfo?(bzbarsky)
Attachment #8918447 - Flags: review?(kmaglione+bmo) → review+
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/518baff0f991 Disable named property object (aka global scope polluter) behavior for all Xrays. r=kmag
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c3368c7a937b followup. Update out-of-date assertions to fix bustage and reopen CLOSED TREE.
Attachment #8918447 - Attachment is obsolete: true
status-firefox57: --- → wontfix
Priority: -- → P2
Comment on attachment 8919142 [details] [diff] [review] With some test fixes to the tests that were relying on the old behavior Review of attachment 8919142 [details] [diff] [review]: ----------------------------------------------------------------- Sorry for the delay. I've been sick most of the week. r=me
Attachment #8919142 - Flags: review?(kmaglione+bmo) → review+
I happens. It's not like I was particularly blocked on this. I hope you're feeling better!
Pushed by bzbarsky@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/bd06b3b18448 Disable named property object (aka global scope polluter) behavior for all Xrays. r=kmag
https://hg.mozilla.org/mozilla-central/rev/bd06b3b18448
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: