Closed Bug 1356275 Opened 8 years ago Closed 8 years ago

stylo: heap write analysis failure on known-unsafe Gecko_GetFontMetrics

Categories

(Core :: CSS Parsing and Computation, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: sfink, Assigned: manishearth)

References

Details

Attachments

(1 file)

bholley suggests: "We should just MOZ_ASSERT(NS_IsMainThread()) in this function until further notice."
Assignee: nobody → manishearth
Priority: -- → P1
Blocks: 1356105
Er, wrong bug
Blocks: 1356458
Comment on attachment 8858195 [details] Bug 1356275 - Assert that we're on the main thread in the unused and unsafe Gecko_GetFontMetrics ; https://reviewboard.mozilla.org/r/130140/#review134966 Sorry this got lost somehow, I only noticed on the review whine. Feel free to ping me for mechanical stuff like this.
Attachment #8858195 - Flags: review?(bobbyholley) → review+
Pushed by manishearth@gmail.com: https://hg.mozilla.org/integration/autoland/rev/9c187a205fc6 Assert that we're on the main thread in the unused and unsafe Gecko_GetFontMetrics ; r=bholley
Pushed by manishearth@gmail.com: https://hg.mozilla.org/integration/autoland/rev/4ad23bc8d5c1 Decrease allowed write hazard threshhold; r=bholley
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: