Closed
Bug 1361176
Opened 8 years ago
Closed 8 years ago
stylo: We scale the font-size too much while inheriting it
Categories
(Core :: CSS Parsing and Computation, enhancement, P2)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
People
(Reporter: emilio, Assigned: manishearth)
References
Details
See bug 1361126 comment 5, which makes this apparent.
I lost track of how this is supposed to work, and I'm fed up with a bunch of other stuff, so I hope Manish (who wrote it) or Cameron (who reviewed it) can take over this.
In particular, when we explicitly inherit font-size (which we do too much right now), we have code that looks like:
let kw_inherited_size = context.style().font_size_keyword.map(|(kw, ratio)| {
SpecifiedValue::Keyword(kw, ratio).to_computed_value(context)
});
That Keyword(..).to_computed_value() scales the font-size if ratio is not one, which looks quite wrong to me when we inherit because of unrelated reasons.
Assignee | ||
Comment 1•8 years ago
|
||
> That Keyword(..).to_computed_value() scales the font-size if ratio is not one, which looks quite wrong to me when we inherit because of unrelated reasons.
It doesn't, it scales the base size to obtain the font size; it doesn't rescale the inherited size (which is not involved)
The problem here is that we persist the keyword even when we obtained the size due to mathml shenanigans.
Patches incoming.
Updated•8 years ago
|
Assignee: nobody → manishearth
Priority: -- → P2
Assignee | ||
Comment 2•8 years ago
|
||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•