Closed Bug 1363574 Opened 8 years ago Closed 8 years ago

stylo: Allow unitless length in SMIL values

Categories

(Core :: CSS Parsing and Computation, enhancement)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: hiro, Assigned: hiro)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

Bug 1363574 - Allow unitless length for SMIL values.
(deleted), text/x-review-board-request
birtles
: review+
Details
We should also support unitless length for SMIL. Currenly in SMIL, we are using Servo_ParseProperty() which specify LengthParsingMode::Default instead of LengthParsingMode::SVG. On the other hand, Servo_ParseProperty and Servo_DeclarationBlock_SetPropertyById (which supports LengthParsingMode::SVG) are pretty similar. We can unify them. In this bug, I am going to replace Servo_ParseProperty with Servo_DeclarationBlock_SetPropertyById and then set LengthParsingMode::SVG for SMIL case.
An initial try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b242547816872365e1248869d21937767a4c67cf I am not sure there are cases using unitless length for SMIL.
Oh idiot. I did pass null insanely.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c7e6b34989da91c6c62923bbfb54b7c346f37934
Summary: Allow unitless length in SMIL values → stylo: Allow unitless length in SMIL values
Comment on attachment 8866166 [details] Bug 1363574 - Factor out common part of Servo_ParseProperty() and set_property(). https://reviewboard.mozilla.org/r/137772/#review140922
Attachment #8866166 - Flags: review?(bbirtles) → review+
Comment on attachment 8866167 [details] Bug 1363574 - Use parse_property for Servo_CSSSupports2() as well. https://reviewboard.mozilla.org/r/137774/#review140926
Attachment #8866167 - Flags: review?(bbirtles) → review+
Comment on attachment 8866168 [details] Bug 1363574 - Allow unitless length for SMIL values. https://reviewboard.mozilla.org/r/137776/#review140930
Attachment #8866168 - Flags: review?(bbirtles) → review+
Attachment #8866166 - Attachment is obsolete: true
Attachment #8866167 - Attachment is obsolete: true
Pushed by hikezoe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/93e1aec3da60 Allow unitless length for SMIL values. r=birtles
https://hg.mozilla.org/mozilla-central/rev/93e1aec3da60
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: