We don't think we're using the theme footers in https://dxr.mozilla.org/mozilla-central/source/browser/base/content/defaultthemes any more, but we're still shipping them. We should delete the footer images from hg, and any references to them. https://dxr.mozilla.org/mozilla-central/search?q=regexp%3A%22%5B0-9%5D%5C.footer.(png%7Cjpg)%22&redirect=false

Did you intend to request review?

(In reply to :Gijs from comment #3) > Did you intend to request review? Just looking for feedback right now, given that I don't understand this code at all. The builds and tests seem to run ok. Who is a good person to review this code? I wasn't sure what to do with all the other references to 'footerURL' in the code: https://dxr.mozilla.org/mozilla-central/search?q=footerURL&redirect=false

(In reply to Chris AtLee [:catlee] from comment #4) > (In reply to :Gijs from comment #3) > > Did you intend to request review? > > Just looking for feedback right now, given that I don't understand this code > at all. The builds and tests seem to run ok. Who is a good person to review > this code? I could, or Dão or Mossop or Jared (:jaws). > I wasn't sure what to do with all the other references to 'footerURL' in the > code: > https://dxr.mozilla.org/mozilla-central/search?q=footerURL&redirect=false The toolkit ones might want to stay if Thunderbird uses them? Here's a narrower query that ignores that and the objdir hits: https://dxr.mozilla.org/mozilla-central/search?q=footerURL+-path%3Atoolkit+-path%3Aobj-x&redirect=false The mobile hit is harmless, so I guess you can leave it... but otherwise I think everything else should go.

Comment on attachment 8869151 [details] Bug 1363853: Remove LWT footers https://reviewboard.mozilla.org/r/140782/#review145036 r=me, though I am a little confused about the toolkit test changes. I don't think those are strictly required. Was there a particular reason to alter those (ie do they all fail if you don't remove the footerURL stuff)? Inasmuch as we still use this stuff on other toolkit apps, perhaps the tests should stay... I don't feel super strongly, though, so it's up to you.

Pushed by catlee@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/26681896ae7b Remove LWT footers r=Gijs