Closed
Bug 1364207
Opened 8 years ago
Closed 8 years ago
histogram_tools.py broken when whitelist is None
Categories
(Toolkit :: Telemetry, defect, P1)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: frank, Assigned: chutten)
References
Details
Attachments
(1 file)
This is breaking some histograms in TMO.
https://pageshot.net/nujLR8jXjGr8gZZn/rpm.newrelic.com
| Comment hidden (mozreview-request) |
|
Reporter | |
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8866952 [details]
bug 1364207 - Guard all uses of whitelists in histogram_tools
https://reviewboard.mozilla.org/r/138560/#review141798
::: toolkit/components/telemetry/histogram_tools.py:263
(Diff revision 1)
> if not expiration:
> return
>
> # We forbid new probes from using "expires_in_version" : "default" field/value pair.
> # Old ones that use this are added to the whitelist.
> + if whitelists is not None:
Probably best to combine these if statements.
Attachment #8866952 -
Flags: review?(fbertsch) → review-
|
||
Updated•8 years ago
|
Assignee: nobody → chutten
Priority: -- → P1
| Comment hidden (mozreview-request) |
|
|
Reporter | |
Comment 4•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8866952 [details]
bug 1364207 - Guard all uses of whitelists in histogram_tools
https://reviewboard.mozilla.org/r/138560/#review142058
Attachment #8866952 -
Flags: review?(fbertsch) → review+
Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/adc8eed5329e
Guard all uses of whitelists in histogram_tools r=frank
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•