Closed
Bug 1366156
Opened 8 years ago
Closed 7 years ago
Child INPUT_EVENT_RESPONSE_MS p50 regressed from 9.28 to 10.22ms on 2017-05-06 build
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
INCOMPLETE
People
(Reporter: ehsan.akhgari, Assigned: farre)
References
Details
Attachments
(2 obsolete files)
Telemetry: https://mzl.la/2rp2aeP
Reporter | ||
Comment 1•8 years ago
|
||
Andreas, I think the telemetry collection code in bug 1322184 may be the reason for this regression...
The good news is that if this is the case, AutoCollectVsyncTelemetry automatically turns itself off for the release channel, so we can just ignore the regression. But we should verify whether this is really the regression we are looking at. I would like to disable this probe for a few days and watch INPUT_EVENT_RESPONSE_MS to see if it drops down and in that case, mark this bug as WONTFIX and move on!
Blocks: 1322184
Keywords: leave-open
Reporter | ||
Comment 2•8 years ago
|
||
Attachment #8869307 -
Flags: review?(afarre)
Assignee | ||
Updated•8 years ago
|
Attachment #8869307 -
Flags: review?(afarre) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 3•8 years ago
|
||
Sorry, shouldn't have set the checkin-needed flag there. Don't know what happened.
Keywords: checkin-needed
Assignee | ||
Comment 4•8 years ago
|
||
What I should've said is that we should probably do this as well.
Assignee: nobody → afarre
Attachment #8869396 -
Flags: review?(ehsan)
Reporter | ||
Comment 5•8 years ago
|
||
Comment on attachment 8869396 [details] [diff] [review]
0001-Bug-1366156-Temporarily-stop-recording-vsync-message.patch
Yeah makes sense. I'll fold this into my patch to make it easier to back the whole thing out after a few days. Thanks!
Attachment #8869396 -
Flags: review?(ehsan) → review+
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dfdebc342d2e
Temporarily disable the collection of content js delay event telemetry probes to investigate whether they are the cause of child process INPUT_EVENT_RESPONSE_MS regressions; r=farre
Comment 7•8 years ago
|
||
bugherder |
Reporter | ||
Comment 8•8 years ago
|
||
Comment on attachment 8869307 [details] [diff] [review]
Temporarily disable the collection of content js delay event telemetry probes to investigate whether they are the cause of child process INPUT_EVENT_RESPONSE_MS regressions
It doesn't look like this has caused any measurable change in the INPUT_EVENT_RESPONSE_MS telemetry probe. I'm going to revert this patch now...
Attachment #8869307 -
Attachment is obsolete: true
Reporter | ||
Updated•8 years ago
|
Attachment #8869396 -
Attachment is obsolete: true
Reporter | ||
Comment 9•8 years ago
|
||
(In reply to :Ehsan Akhgari (super long backlog, slow to respond) from comment #8)
> Comment on attachment 8869307 [details] [diff] [review]
> Temporarily disable the collection of content js delay event telemetry
> probes to investigate whether they are the cause of child process
> INPUT_EVENT_RESPONSE_MS regressions
>
> It doesn't look like this has caused any measurable change in the
> INPUT_EVENT_RESPONSE_MS telemetry probe. I'm going to revert this patch
> now...
https://hg.mozilla.org/integration/mozilla-inbound/rev/1658b1c63226
Comment 10•8 years ago
|
||
Merge of backout:
https://hg.mozilla.org/mozilla-central/rev/1658b1c63226
Comment 11•8 years ago
|
||
Backed out bug 1352889 today to see whether it is the cause.
Comment 12•7 years ago
|
||
The backout of bug 1352889 didn't make any difference. I'm going to reland it, but that means you need to look for a different culprit here.
Flags: needinfo?(kchen)
Comment 13•7 years ago
|
||
See bug 1362094 comment 25. We decided this bug is INCOMPLETE due to the limitation of the probes.
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(kchen)
Resolution: --- → INCOMPLETE
Comment 14•7 years ago
|
||
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in
before you can comment on or make changes to this bug.
Description
•