Closed Bug 13678 Opened 25 years ago Closed 5 years ago

Redesign of header handling

Categories

(MailNews Core :: Backend, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: BenB, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: helpwanted)

Attachments

(2 files)

The headers code is wierd. There're at least 5 different definitions for headers. Trying to add a header will be not just painful, but be a potential source for bugs. I'd vote for one or two classes, which (1) store the values and (2) know the protocol. Some relevant files: http://lxr.mozilla.org/seamonkey/source/mailnews/compose/public/nsIMsgCompFields.idl http://lxr.mozilla.org/seamonkey/source/mailnews/compose/src/nsMsgCompFields.cpp#573 http://lxr.mozilla.org/seamonkey/source/mailnews/mime/public/nsMailHeaders.h http://lxr.mozilla.org/seamonkey/source/include/libmime.h http://lxr.mozilla.org/seamonkey/source/mailnews/compose/src/nsMsgCompUtils.cpp#197 (UI files not listet)
Status: NEW → ASSIGNED
Target Milestone: M14
Severity: minor → normal
Priority: P3 → P1
Status: ASSIGNED → NEW
Priority: P1 → P3
Whiteboard: [HELP WANTED]
Target Milestone: M14 → M20
Giving up for now :-(. Maybe later.
Summary: Redesign of header handling → [HELP WANTED] Redesign of header handling
Assignee: mozilla → nobody
Blocks: 12306
Keywords: helpwanted
Summary: [HELP WANTED] Redesign of header handling → Redesign of header handling
Whiteboard: [HELP WANTED]
Target Milestone: M20
Attached file Design as DIA 0.40 UML chart (deleted) —
Attached image Design as PNG (deleted) —
This attached proposed design is the result of the mentioned discussion on .mailnews. Not sure, if all this (including this bug) is still valid. Adding alecf to CC, as he knows the current infrastructure well. I added descriptions for arrows, because I don't know UML. Please point me to errors.
QA Contact: lchiang → nobody
I am beginning a long an arduous process which hopefully will result in a rewrite of the libmime code in a nice C++ish XPCOMish way (see bug 248846). If anyone is interested in making such changes, I believe it will be easier when there is no more legacy code in the obfuscated pseudo-object system which is hardly interoperable with the rest of Mozilla. For the time being it would be easier for me if the libmime code were left untouched. If anybody finds it urgent to work on this bug right now, please coordinate with me. For now, I am marking this bug dependant on the rewrite bug.
Depends on: 248846
Product: MailNews → Core
QA Contact: nobody → backend
Product: Core → MailNews Core

jsmime largely changed how this works. There's stuff to be done yet of course, and certainly in the compose code. But I think we can close this one.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: