Closed
Bug 1369855
Opened 7 years ago
Closed 7 years ago
Update sinon.js to version 2.3.2
Categories
(Testing :: General, enhancement)
Tracking
(firefox55 fixed)
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: eoger, Assigned: eoger)
Details
Attachments
(1 file)
At the moment we are using sinon-1.16.1.js
We rely a lot on mocks in Sync testing code, and this old version of sinon.js doesn't mock getters.
|
Assignee | |
Comment 1•7 years ago
|
||
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 3•7 years ago
|
||
Comment on attachment 8874970 [details]
Bug 1369855 - Update sinon.js to version 2.3.2.
Sorry I wasn't really sure who to ask for review so I just went with what the "suggest reviewers" popup suggested.
Attachment #8874970 -
Flags: review?(ahalberstadt)
|
||
Comment 4•7 years ago
|
||
Hey no worries, though I'm not a good reviewer for this. Looks like :markh reviewed the patch that added sinon in the first place, so maybe he'd be a good candidate (or at least have a better idea who to re-direct this to).
|
|
||
Updated•7 years ago
|
Attachment #8874970 -
Flags: review?(ahalberstadt) → review?(markh)
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 6•7 years ago
|
||
Failing tests fixed
| Comment hidden (mozreview-request) |
|
||
Comment 8•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8874970 [details]
Bug 1369855 - Update sinon.js to version 2.3.2.
https://reviewboard.mozilla.org/r/145394/#review151068
This looks fine to me, thanks.
Attachment #8874970 -
Flags: review?(markh) → review+
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d397d4c72d75
Update sinon.js to version 2.3.2. r=markh
|
||
Comment 10•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•