Closed
Bug 1370404
Opened 7 years ago
Closed 5 years ago
Add margin, padding, and border axis-specific shorthands
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
People
(Reporter: jkt, Assigned: MatsPalmgren_bugz)
References
(Blocks 1 open bug)
Details
Reporter | ||
Comment 1•7 years ago
|
||
Sorry for the super lightweight comment.
We should consider supporting these shorthands to help ease boilerplate in CSS.
Blocks: css-logical-props
Summary: Asds margin, padding, and border axis-specific shorthands → Add margin, padding, and border axis-specific shorthands
Assignee | ||
Comment 2•7 years ago
|
||
Note also: https://github.com/w3c/csswg-drafts/issues/1282
Assuming that's adopted, do we really need to support both?
It seems it makes the shorthands added in 1279 redundant?
Severity: normal → enhancement
OS: Unspecified → All
Hardware: Unspecified → All
See Also: → https://github.com/w3c/csswg-drafts/issues/1282
Reporter | ||
Comment 3•7 years ago
|
||
Both appear to be closed in the same PR from fantasai from what I can see. Am I missing some conversation somewhere perhaps?
Assignee | ||
Comment 4•7 years ago
|
||
https://github.com/w3c/csswg-drafts/issues/1282#issuecomment-298204874
says "Sorry; typo in commit message. :/" and then she reopened it.
Reporter | ||
Comment 5•7 years ago
|
||
Ah indeed sorry.
Fantasai, dbaron do you know the current spec status for these two shorthand types?
Flags: needinfo?(fantasai.bugs)
Flags: needinfo?(dbaron)
Comment 6•7 years ago
|
||
I tend to think we should wait to implement these until the spec is in CR or there's some other declaration that they're stable. I'm not particularly familiar with the spec, but my impression is that they're probably not stable yet, and there isn't a strong reason to force them to stabilize quickly.
Flags: needinfo?(dbaron)
Reporter | ||
Comment 7•7 years ago
|
||
No worries, I just wanted to raise as I was asked to use them and realised we didn't support etc.
Thanks
Flags: needinfo?(fantasai.bugs)
Updated•7 years ago
|
Priority: -- → P3
Updated•7 years ago
|
Keywords: dev-doc-needed
Comment 8•7 years ago
|
||
According to the following issue in the spec:
https://drafts.csswg.org/css-logical-1/#issue-b84049ec
The shorthans margin-block|inline, padding-block|inline, inset-block|inline, ...
are ready for shippping.
What's not ready yet is:
"The logical keyword on shorthands, because the name of the keyword may change
or it may be replaced by some other syntactic marker."
But that's basically bug #1289155.
Comment 9•5 years ago
|
||
Mats, can this be closed ? I'm pretty sure this has been implemented in other places and the logical keyword is covered by bug 1289155.
Flags: needinfo?(mats)
Assignee | ||
Comment 10•5 years ago
|
||
Yeah, we shipped these last year. bug 1519847 etc
Assignee: nobody → mats
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(mats)
Resolution: --- → FIXED
Updated•5 years ago
|
Keywords: dev-doc-needed
You need to log in
before you can comment on or make changes to this bug.
Description
•