Closed
Bug 1371488
Opened 7 years ago
Closed 7 years ago
stylo: @import rule which fails to load leads to failing of constructing @import rule wrapper object
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: xidorn, Assigned: xidorn)
References
Details
Attachments
(2 files)
No description provided.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•7 years ago
|
||
This fixes the issue mentioned in bug 1368651 comment 1.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → xidorn+moz
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8875946 [details]
Bug 1371488 part 1 - Don't create empty servo sheet for stylesheet of @import rule when loading failed.
https://reviewboard.mozilla.org/r/147350/#review151642
r=me, but any chance to add a test for this?
Attachment #8875946 -
Flags: review?(emilio+bugs) → review+
Assignee | ||
Comment 4•7 years ago
|
||
I guess WPT already includes some test for this? Probably not a bad idea to have one in our style mochitest as well, though. Will add one.
Comment 5•7 years ago
|
||
WPT has a test which fails because of this (https://hg.mozilla.org/try/diff/094e02785692/testing/web-platform/meta/cssom/index-003.html.ini) but the primary purpose of the test is something else.
Blocks: stylo-wpt
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8876940 [details]
Bug 1371488 part 2 - Add test for this bug.
https://reviewboard.mozilla.org/r/148268/#review152636
Thanks for adding the test! :)
::: layout/style/test/test_bug1371488.html:14
(Diff revision 1)
> + </style>
> +</head>
> +<body>
> +<pre id="test">
> +<script>
> + let sheet = document.getElementById("test").sheet;
nit: The id is duplicated in this document. It happens to do the right thing, but I'd rather change the id of the `<style>` or the `<pre>` to something else.
Attachment #8876940 -
Flags: review?(emilio+bugs) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 10•7 years ago
|
||
mozreview-review-reply |
Comment on attachment 8876940 [details]
Bug 1371488 part 2 - Add test for this bug.
https://reviewboard.mozilla.org/r/148268/#review152636
> nit: The id is duplicated in this document. It happens to do the right thing, but I'd rather change the id of the `<style>` or the `<pre>` to something else.
Changed id of `<pre>` to "log" instead.
Comment 11•7 years ago
|
||
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/771edfb05262
part 1 - Don't create empty servo sheet for stylesheet of @import rule when loading failed. r=emilio
https://hg.mozilla.org/integration/autoland/rev/2b2e73c263b0
part 2 - Add test for this bug. r=emilio
Comment 12•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/771edfb05262
https://hg.mozilla.org/mozilla-central/rev/2b2e73c263b0
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•