Closed Bug 1376911 Opened 7 years ago Closed 5 years ago

Clicking history dropmarker on URLBar shows nothing for a fresh new user

Categories

(Firefox :: Address Bar, defect, P3)

56 Branch
defect

Tracking

()

RESOLVED FIXED
Firefox 75

People

(Reporter: rexboy, Unassigned)

References

Details

(Whiteboard: [fxsearch])

Attachments

(2 files)

STR: 1. open a fresh profile by executing firefox -P, clicking new profile. 2. click on the history dropmarker. Expected: Dropdown shows. Actual: Nothing happened. see: https://bugzilla.mozilla.org/attachment.cgi?id=8881826
Summary: Clicking history dropmarker shows nothing for a fresh new user → Clicking history dropmarker on URLBar shows nothing for a fresh new user
Whiteboard: [fxsearch]
Mak has proposed to change the default result for clicking history dropmarker. Quoting from bug 1371542 comment 44: (In reply to Marco Bonardo [::mak] from comment #44) > (In reply to :Gijs from comment #43) > > Well, this is targeted for 57, so it seems to me we have time to just fix > > the url bar instead of working around the issue only to then remove the code > > again once we fix things 'properly'. > > Note that there's no definition of "properly" yet. > I could propose to make the default behavior returning anything, restrict to > bookmarks if history is disabled, to history if bookmarks are disabled, and > to openPage if both are disabled. > The code is here: > http://searchfox.org/mozilla-central/rev/ > fdb811340ac4e6b93703d72ee99217f3b1d250ac/toolkit/components/places/ > UnifiedComplete.js#484 > > But honestly I have no data to tell if the new setting would be better than > the old one. For sure "typed" doesn't seem to make a lot of sense, so > off-hand I'd be fine with the change. > > > Note that I'm also not sure how our search deals work, but if this impacts > > those because now we search for "Firefox" all the time, that's potentially > > not a desired side-effect... > > We don't actually "search" for it, we're just fetching suggestions, so I > don't think it would be a problem. Yet we have no data to decide if the change brings better experience, I'll collect some UX's inputs before moving on.
Attached image screenshot for a fresh user (deleted) —
Using BEHAVIOR_HISTORY + BEHAVIOR_BOOKMARK + BEHAVIOR_OPENPAGE + BEHAVIOR_TAG for a fresh user
Priority: -- → P2
Blocks: 1446325
No longer blocks: 1446325
Depends on: 1547279
Priority: P2 → P3

Fixed by megabar.

Status: NEW → RESOLVED
Closed: 5 years ago
Depends on: urlbar-update-1
Resolution: --- → FIXED
Target Milestone: --- → Firefox 75
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: