Closed
Bug 1378247
Opened 7 years ago
Closed 7 years ago
[RTL] Scrollbar moves in opposite direction with horizontal scrolling
Categories
(Core :: Panning and Zooming, defect, P2)
Tracking
()
VERIFIED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox54 | --- | unaffected |
firefox55 | - | fixed |
firefox56 | --- | fixed |
People
(Reporter: over68, Assigned: kats)
References
Details
(Keywords: regression)
Attachments
(2 files)
(deleted),
text/x-review-board-request
|
botond
:
review+
jcristau
:
approval-mozilla-beta+
|
Details |
(deleted),
text/html
|
Details |
Steps to reproduce:
1. Open https://onedrive.live.com/download?cid=F96BA52A2AF70D03&resid=F96BA52A2AF70D03!1476&authkey=APfKZqnv1yfw-RE.
2. Go to the scroll box.
3. Drag the scrollbar left.
Actual results:
Scrollbar moves in opposite direction with horizontal scrolling.
See https://www.youtube.com/watch?v=RQ7jw_3S_mY
Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=4cbc57e29e25e8abe783b16915bd74325a040b02&tochange=d7518eef6b8924b4ddad6cdeeae4eed1c6129b26
Regressed by: bug 1324117
Blocks: 1324117
Keywords: regression
Pushlog with enabled apz.drag.enabled = true;
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=bd2089fe075e09bb3cbee1535e8ae960598f65c5&tochange=b72ab182dd554343b504a771e535214de53b5d6f
Regressed by: bug 1273137
Blocks: 1273137
Comment 3•7 years ago
|
||
[Tracking Requested - why for this release]:
Status: UNCONFIRMED → NEW
status-firefox54:
--- → unaffected
status-firefox55:
--- → affected
status-firefox56:
--- → affected
status-firefox-esr52:
--- → unaffected
tracking-firefox55:
--- → ?
Ever confirmed: true
Assignee | ||
Updated•7 years ago
|
Blocks: async-scrollbar-drag
Priority: -- → P2
Summary: Scrollbar moves in opposite direction with horizontal scrolling → [RTL] Scrollbar moves in opposite direction with horizontal scrolling
Comment hidden (mozreview-request) |
Assignee | ||
Comment 6•7 years ago
|
||
For posterity, attaching the test page as an attachment to the bug.
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8883669 [details]
Bug 1378247 - Properly handle async scrollbar-dragging of RTL scrollframes.
https://reviewboard.mozilla.org/r/154576/#review159686
Thanks for looking at this!
Attachment #8883669 -
Flags: review?(botond) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b9aed48eb292
Properly handle async scrollbar-dragging of RTL scrollframes. r=botond
Comment 9•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Assignee | ||
Comment 10•7 years ago
|
||
Can you confirm the issue is fixed for you in today's nightly? Thanks!
Flags: needinfo?(over68)
Reporter | ||
Comment 11•7 years ago
|
||
I confirm this bug has been fixed in the latest nightly build.
Flags: needinfo?(over68)
Assignee | ||
Comment 12•7 years ago
|
||
Comment on attachment 8883669 [details]
Bug 1378247 - Properly handle async scrollbar-dragging of RTL scrollframes.
Approval Request Comment
[Feature/Bug causing the regression]: Async scrollbar dragging
[User impact if declined]: scrollbar dragging on RTL scrollframes doesn't work properly
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no, already verified
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: not really
[Why is the change risky/not risky?]: small code change to remove an assumption about valid scroll positions
[String changes made/needed]: none
Attachment #8883669 -
Flags: approval-mozilla-beta?
Assignee | ||
Updated•7 years ago
|
Status: RESOLVED → VERIFIED
Comment 13•7 years ago
|
||
Comment on attachment 8883669 [details]
Bug 1378247 - Properly handle async scrollbar-dragging of RTL scrollframes.
fix for apz with rtl, verified in nightly, beta55+
Attachment #8883669 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•7 years ago
|
Comment 14•7 years ago
|
||
bugherder uplift |
Comment 15•7 years ago
|
||
(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #12)
> [Is this code covered by automated tests?]: no
> [Has the fix been verified in Nightly?]: yes
> [Needs manual test from QE? If yes, steps to reproduce]: no, already verified
Setting qe-verify- based on Kartikaya's assessment on manual testing needs.
Flags: qe-verify-
You need to log in
before you can comment on or make changes to this bug.
Description
•