Closed
Bug 1378853
Opened 7 years ago
Closed 7 years ago
Stop using sdk/core/heritage in DevTools reflow actor
Categories
(DevTools :: General, enhancement, P1)
DevTools
General
Tracking
(firefox56 fixed)
RESOLVED
FIXED
Firefox 56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: sole, Assigned: sole)
References
Details
(Whiteboard: [nosdk])
Attachments
(1 file, 1 obsolete file)
Used in: devtools/server/actors/reflow.js
More details to follow as we triage.
|
||
Updated•7 years ago
|
Flags: qe-verify-
Priority: -- → P2
Whiteboard: [nosdk]
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → sole
|
|
||
Updated•7 years ago
|
Status: NEW → ASSIGNED
Priority: P2 → P1
Target Milestone: --- → Firefox 56
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8887858 [details]
Bug 1378853 - Stop using sdk/core/heritage in DevTools reflow actor.
https://reviewboard.mozilla.org/r/158786/#review164068
Looks good to me!
::: devtools/server/actors/reflow.js:473
(Diff revision 1)
> * Reports window resize events on the tabActor's windows.
> * @extends Observable
> * @param {TabActor} tabActor
> * @param {Function} callback Executed everytime a resize occurs
> */
> -function WindowResizeObserver(tabActor, callback) {
> +
nit: remove extra line between comment block and class
Attachment #8887858 -
Flags: review?(jdescottes) → review+
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8887873 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/1efe09393b6c
Stop using sdk/core/heritage in DevTools reflow actor. r=jdescottes
Keywords: checkin-needed
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•