Closed
Bug 1379891
Opened 7 years ago
Closed 7 years ago
Remove nsPIEditorTransaction
Categories
(Core :: DOM: Editor, enhancement, P3)
Core
DOM: Editor
Tracking
()
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: m_kato, Assigned: adrian17)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
This is comment of this interface.
* This interface is implemented by every transaction created by this
* editor implementation. It is used to help us distinguish our internal
* transactions from those generated by 3rd party extensions.
So after we don't support 3rd party XPCOM extension, we can remove this.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Reporter | ||
Comment 3•7 years ago
|
||
Comment on attachment 8941583 [details]
Bug 1379891 - remove nsPIEditorTransaction interface, GetTxnDescription methods.
Reviewboard causes internal error to modify flags and add reviewer...
I look OK. Nakano-san, do you have any objections to remove this?
nsPIEditorTransaction uses to detect current ITransaction is editor's transaction. Although nsITransaction interface uses places database too, since we cannot use XPCOM from Firefox extension, I think that we can remove this interface. Although Thunderbird can still use this interface from extension...
Attachment #8941583 -
Flags: review?(masayuki)
Attachment #8941583 -
Flags: review?(m_kato)
Attachment #8941583 -
Flags: review+
Comment 4•7 years ago
|
||
Comment on attachment 8941583 [details]
Bug 1379891 - remove nsPIEditorTransaction interface, GetTxnDescription methods.
Looks like that you forgot to do |hg remove editor/nsPIEditorTransaction.idl|. Please remove the file and merge it to this commit before landing.
Attachment #8941583 -
Flags: review?(masayuki) → review+
Comment 5•7 years ago
|
||
> Although nsITransaction interface uses places database too, since we cannot use XPCOM from Firefox extension,
> I think that we can remove this interface.
Yes, and if we make Places not use nsITransaction, we could remove the interface. However, I don't think that it's worthwhile at least for now.
> Although Thunderbird can still use this interface from extension...
Do you mean some addons for Thunderbird still use nsPIEditorTransaction? But I think that they can just stop using it since any addons shouldn't create its own transaction and insert it to transaction manger of editor.
Comment 6•7 years ago
|
||
(Although dxr for addon doesn't work since yesterday. So, I haven't checked how they use nsPIEditorTransaction actually yet.)
Assignee | ||
Comment 7•7 years ago
|
||
Looks like there is one use of txnDescription getter in comm-central, in debugQA extension:
https://searchfox.org/comm-central/source/suite/extensions/debugQA/content/debugQAEditorOverlay.js#412
Should the getter be moved to nsITransaction to keep it working, or deal with it the other way?
Comment 8•7 years ago
|
||
No. We've already ignored the QA addon when we change some API. Looks like that SeaMonkey isn't active project and its extensions isn't necessary for users.
Comment hidden (mozreview-request) |
Comment 10•7 years ago
|
||
Pushed by ecoal95@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a50f8a3e3701
remove nsPIEditorTransaction interface, GetTxnDescription methods. r=m_kato,masayuki
Comment 11•7 years ago
|
||
Helped Adrian land the patch since he told me that MozReview got confused.
Comment 12•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox59:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Reporter | ||
Comment 13•7 years ago
|
||
Comment on attachment 8941583 [details]
Bug 1379891 - remove nsPIEditorTransaction interface, GetTxnDescription methods.
Although this is already landed with r+...
Attachment #8941583 -
Flags: review?(m_kato) → review+
Reporter | ||
Updated•7 years ago
|
Assignee: nobody → adrian.wielgosik
You need to log in
before you can comment on or make changes to this bug.
Description
•