Closed
Bug 1380126
Opened 7 years ago
Closed 7 years ago
Add manifestparser to mozharness
Categories
(Testing :: General, enhancement)
Testing
General
Tracking
(firefox57 fixed)
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: gbrown, Assigned: gbrown)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
Callek
:
review+
|
Details | Diff | Splinter Review |
For bug 1357513, I want to implement a new "test verification" feature, such that, when a new test is added, or a test is modified, it is subjected to additional verification.
In support of that goal, in bug 1380122, I want to enhance mozharness to recognize when a new/modified file is a test file. To do that, mozharness must be able to parse manifests, so I need to access the mozbase manifestparser from mozharness.
Assignee | ||
Comment 1•7 years ago
|
||
This just adds a copy of manifestparser - from testing/mozbase/manifestparser in mozilla-central - to mozharness. This mirrors what has been done for other mozbase modules, like mozinfo and mozprocess, required in mozharness.
Of course I don't like to see files copied like this, but I don't see a viable alternative.
Attachment #8885436 -
Flags: review?(bugspam.Callek)
Comment 2•7 years ago
|
||
Comment on attachment 8885436 [details] [diff] [review]
add a copy of manifestparser to mozharness
Review of attachment 8885436 [details] [diff] [review]:
-----------------------------------------------------------------
I'm going to just stamp this, with the one comment that I'd prefer if you do `hg copy` rather than simply `cp ..; hg add ...` so that the history is retained, along with this commit message.
I'm not a big fan of this copy either but I don't know of a better solution offhand.
Attachment #8885436 -
Flags: review?(bugspam.Callek) → review+
Assignee | ||
Comment 3•7 years ago
|
||
Thanks. Going ahead with 'hg copy'...
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/28e708860c3d
Add a copy of mozbase' manifestparser to mozharness; r=Callek
Comment 5•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•