Closed Bug 1382138 Opened 7 years ago Closed 7 years ago

stylo: make '-moz-appearance' animatable

Categories

(Core :: CSS Parsing and Computation, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: daisuke, Assigned: daisuke)

References

Details

Attachments

(2 files, 1 obsolete file)

'-moz-appearance' should animate discretely. To realize this, we will fix bug 1371809 at first.
Depends on: 1371809
Priority: -- → P2
I discussed with Brian. In this time, we implement using non_upper_case_globals instead of fixing bug 1371809. try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=386e7eef67b2ee1100e83369d2a68f765af438d9
Comment on attachment 8896768 [details] Bug 1382138 - Part 2: Add -moz-appearance property to moz prefixed properties test. https://reviewboard.mozilla.org/r/168052/#review173178
Attachment #8896768 - Flags: review?(hikezoe) → review+
Attachment #8896767 - Flags: review?(hikezoe) → review+
(In reply to Daisuke Akatsuka (:daisuke) from comment #3) > I discussed with Brian. > In this time, we implement using non_upper_case_globals instead of fixing > bug 1371809. Would you mind explaining the reason why? I think we don't need to rush to make this moz prefixed property animatable, I guess bug 1371809 (and depending one) could be fixed at least within a few weeks. There were unclear things in those bugs?
(In reply to Hiroyuki Ikezoe (:hiro) from comment #6) > (In reply to Daisuke Akatsuka (:daisuke) from comment #3) > > I discussed with Brian. > > In this time, we implement using non_upper_case_globals instead of fixing > > bug 1371809. > > Would you mind explaining the reason why? I think we don't need to rush to > make this moz prefixed property animatable, I guess bug 1371809 (and > depending one) could be fixed at least within a few weeks. There were > unclear things in those bugs? We need to drive P1/P2 Stylo bugs down quickly, ideally close to zero by the end of this week. Daisuke suggested it was going to take him quite a while to fix bug 1371809. Furthermore, since there's a good chance this is used in the wild and since it blocks turning on a few tests we shouldn't make bug 1371809 block this. Let's get the content fixed and tests turned on then tidy things up in a non-blocking follow-up.
Attached file Servo PR 18066 (deleted) —
When this lands, we can stop skipping mozilla/test_discrete-animations.html
Attachment #8896767 - Attachment is obsolete: true
Pushed by dakatsuka@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1eb2225325f3 Part 2: Add -moz-appearance property to moz prefixed properties test. r=hiro
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: