Closed
Bug 1382578
Opened 7 years ago
Closed 7 years ago
Fix 4 tests failures on devtools/client/debugger/new due the EventEmitter refactoring
Categories
(DevTools :: Debugger, enhancement, P2)
DevTools
Debugger
Tracking
(firefox57 fix-optional)
RESOLVED
DUPLICATE
of bug 1384546
Tracking | Status | |
---|---|---|
firefox57 | --- | fix-optional |
People
(Reporter: zer0, Unassigned)
References
Details
Failing tests:
devtools/client/debugger/new/test/mochitest/browser_dbg-breaking.js
devtools/client/debugger/new/test/mochitest/browser_dbg-breakpoints-reloading.js
devtools/client/debugger/new/test/mochitest/browser_dbg-chrome-create.js
devtools/client/debugger/new/test/mochitest/browser_dbg-chrome-debugging.js
The refactoring is currently only on:
https://github.com/zer0/gecko/tree/event-emitter-1381542
We need to address the test failures before land this patch in m-c.
Reporter | ||
Comment 1•7 years ago
|
||
Here the original try build with the failures:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=bba13e27a2371fa8aad68b9b227534b31829cb0d
Those failures are most likely due the breaking change in how the `EventEmitter` emits event.
Previously, the first argument was the event type:
myEmitter.on("custom-event", (eventType, message) => { ... });
Now the first argument is the message:
myEmitter.on("custom-event", (message) => { ... });
In the majority of the scenario the `eventType` is ignored by our code, so we should just remove it from the function's signature.
For more details and edge cases, see: https://github.com/devtools-html/snippets-for-removing-the-sdk/#events
Updated•7 years ago
|
Flags: qe-verify-
Priority: -- → P2
Reporter | ||
Updated•7 years ago
|
Whiteboard: [nosdk]
Updated•7 years ago
|
status-firefox57:
--- → fix-optional
Updated•7 years ago
|
Blocks: dt-polish-debt
Updated•7 years ago
|
No longer blocks: dt-polish-debt
Updated•7 years ago
|
Component: Developer Tools → Developer Tools: Debugger
Comment 2•7 years ago
|
||
This appears to have been fixed by one of the other refactoring bugs. Closing this as a duplicate
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•