Failing tests: devtools/client/inspector/markup/test/browser_markup_accessibility_focus_blur.js devtools/client/inspector/markup/test/browser_markup_accessibility_navigation.js devtools/client/inspector/markup/test/browser_markup_accessibility_navigation_after_edit.js devtools/client/inspector/markup/test/browser_markup_accessibility_semantics.js devtools/client/inspector/markup/test/browser_markup_anonymous_01.js devtools/client/inspector/markup/test/browser_markup_anonymous_03.js devtools/client/inspector/markup/test/browser_markup_anonymous_04.js devtools/client/inspector/markup/test/browser_markup_copy_image_data.js devtools/client/inspector/markup/test/browser_markup_css_completion_style_attribute_01.js devtools/client/inspector/markup/test/browser_markup_css_completion_style_attribute_02.js devtools/client/inspector/markup/test/browser_markup_css_completion_style_attribute_03.js devtools/client/inspector/markup/test/browser_markup_dragdrop_autoscroll_01.js devtools/client/inspector/markup/test/browser_markup_dragdrop_autoscroll_02.js devtools/client/inspector/markup/test/browser_markup_dragdrop_distance.js devtools/client/inspector/markup/test/browser_markup_dragdrop_draggable.js devtools/client/inspector/markup/test/browser_markup_dragdrop_dragRootNode.js devtools/client/inspector/markup/test/browser_markup_dragdrop_escapeKeyPress.js devtools/client/inspector/markup/test/browser_markup_dragdrop_invalidNodes.js devtools/client/inspector/markup/test/browser_markup_dragdrop_reorder.js devtools/client/inspector/markup/test/browser_markup_events-windowed-host.js devtools/client/inspector/markup/test/browser_markup_events_01.js devtools/client/inspector/markup/test/browser_markup_events_02.js devtools/client/inspector/markup/test/browser_markup_events_03.js devtools/client/inspector/markup/test/browser_markup_events_04.js devtools/client/inspector/markup/test/browser_markup_events_click_to_close.js devtools/client/inspector/markup/test/browser_markup_events_jquery_1.0.js devtools/client/inspector/markup/test/browser_markup_events_jquery_1.1.js devtools/client/inspector/markup/test/browser_markup_events_jquery_1.11.1.js devtools/client/inspector/markup/test/browser_markup_events_jquery_1.2.js devtools/client/inspector/markup/test/browser_markup_events_jquery_1.3.js devtools/client/inspector/markup/test/browser_markup_events_jquery_1.4.js devtools/client/inspector/markup/test/browser_markup_events_jquery_1.6.js devtools/client/inspector/markup/test/browser_markup_events_jquery_1.7.js devtools/client/inspector/markup/test/browser_markup_events_jquery_2.1.1.js devtools/client/inspector/markup/test/browser_markup_events_react_development_15.4.1.js devtools/client/inspector/markup/test/browser_markup_events_react_development_15.4.1_jsx.js devtools/client/inspector/markup/test/browser_markup_events_react_production_15.3.1.js devtools/client/inspector/markup/test/browser_markup_events_react_production_15.3.1_jsx.js devtools/client/inspector/markup/test/browser_markup_events_source_map.js devtools/client/inspector/markup/test/browser_markup_html_edit_01.js devtools/client/inspector/markup/test/browser_markup_html_edit_02.js devtools/client/inspector/markup/test/browser_markup_html_edit_03.js devtools/client/inspector/markup/test/browser_markup_image_tooltip.js devtools/client/inspector/markup/test/browser_markup_image_tooltip_mutations.js devtools/client/inspector/markup/test/browser_markup_keybindings_01.js devtools/client/inspector/markup/test/browser_markup_keybindings_04.js devtools/client/inspector/markup/test/browser_markup_keybindings_delete_attributes.js devtools/client/inspector/markup/test/browser_markup_keybindings_scrolltonode.js devtools/client/inspector/markup/test/browser_markup_links_01.js devtools/client/inspector/markup/test/browser_markup_links_02.js devtools/client/inspector/markup/test/browser_markup_links_03.js devtools/client/inspector/markup/test/browser_markup_links_04.js devtools/client/inspector/markup/test/browser_markup_links_05.js devtools/client/inspector/markup/test/browser_markup_links_06.js devtools/client/inspector/markup/test/browser_markup_links_07.js devtools/client/inspector/markup/test/browser_markup_mutation_01.js The refactoring is currently only on: https://github.com/zer0/gecko/tree/event-emitter-1381542 We need to address the test failures before land this patch in m-c.

Here the original try build with the failures: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bba13e27a2371fa8aad68b9b227534b31829cb0d Those failures are most likely due the breaking change in how the `EventEmitter` emits event. Previously, the first argument was the event type: myEmitter.on("custom-event", (eventType, message) => { ... }); Now the first argument is the message: myEmitter.on("custom-event", (message) => { ... }); In the majority of the scenario the `eventType` is ignored by our code, so we should just remove it from the function's signature. For more details and edge cases, see: https://github.com/devtools-html/snippets-for-removing-the-sdk/#events

Comment on attachment 8959150 [details] Bug 1382585 - update inspector/markup to new event emitter. https://reviewboard.mozilla.org/r/228016/#review233910

Pushed by ystartsev@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0b77c1e6a87e update inspector/markup to new event emitter. r=pbro