Failing tests: devtools/client/inspector/shared/test/browser_styleinspector_context-menu-copy-color_01.js devtools/client/inspector/shared/test/browser_styleinspector_context-menu-copy-color_02.js devtools/client/inspector/shared/test/browser_styleinspector_context-menu-copy-urls.js devtools/client/inspector/shared/test/browser_styleinspector_csslogic-content-stylesheets.js devtools/client/inspector/shared/test/browser_styleinspector_refresh_when_active.js devtools/client/inspector/shared/test/browser_styleinspector_tooltip-background-image.js devtools/client/inspector/shared/test/browser_styleinspector_tooltip-longhand-fontfamily.js devtools/client/inspector/shared/test/browser_styleinspector_tooltip-multiple-background-images.js devtools/client/inspector/shared/test/browser_styleinspector_tooltip-shorthand-fontfamily.js devtools/client/inspector/shared/test/browser_styleinspector_tooltip-size.js The refactoring is currently only on: https://github.com/zer0/gecko/tree/event-emitter-1381542 We need to address the test failures before land this patch in m-c.

Here the original try build with the failures: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bba13e27a2371fa8aad68b9b227534b31829cb0d Those failures are most likely due the breaking change in how the `EventEmitter` emits event. Previously, the first argument was the type event: myEmitter.on("custom-event", (eventType, message) => { ... }); Now the first argument is the message: myEmitter.on("custom-event", (message) => { ... }); In the majority of the scenario the `eventType` is ignored by our code, so we should just remove it from the function's signature. For more details, see: https://github.com/devtools-html/snippets-for-removing-the-sdk/#events

Comment on attachment 8959191 [details] Bug 1382600 - update inspector/shared to new event emitter. https://reviewboard.mozilla.org/r/228076/#review233968 sounds good to me, thanks yulia :)

Comment on attachment 8959191 [details] Bug 1382600 - update inspector/shared to new event emitter. https://reviewboard.mozilla.org/r/228076/#review234098

Pushed by ystartsev@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/189ee552e4a4 update inspector/shared to new event emitter. r=nchevobbe,pbro