Both 'image-orientation' and 'paint-order' should animate discretely.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7234dc364ee804529baf6013807eed128acf5491

Comment on attachment 8893274 [details] Bug 1386963 - Part 3: remove test fail annotations from meta in wpt. https://reviewboard.mozilla.org/r/164322/#review169640

Comment on attachment 8893272 [details] Bug 1386963 - Part 1: make paint-order animatable. https://reviewboard.mozilla.org/r/164318/#review169648 ::: servo/components/style/properties/gecko.mako.rs:5087 (Diff revision 1) > + use self::longhands::paint_order::SpecifiedValue; > + > + if self.gecko.mPaintOrder == structs::NS_STYLE_PAINT_ORDER_NORMAL as u8 { > + return SpecifiedValue(NORMAL); > + } Use computed_value::T instead of SpecifiedValue. ::: servo/components/style/properties/gecko.mako.rs:5093 (Diff revision 1) > + > + if self.gecko.mPaintOrder == structs::NS_STYLE_PAINT_ORDER_NORMAL as u8 { > + return SpecifiedValue(NORMAL); > + } > + > + let mask = (1 << structs::NS_STYLE_PAINT_ORDER_BITWIDTH) - 1; Can we define this as const u8? ::: servo/components/style/properties/gecko.mako.rs:5105 (Diff revision 1) > + structs::NS_STYLE_PAINT_ORDER_MARKERS => MARKERS, > + _ => unreachable!(), > + }; > + order |= value << (pos * SHIFT); > + }; > + SpecifiedValue(order) Use computed_value:T.

Comment on attachment 8893273 [details] Bug 1386963 - Part 2: make image-orientation animatable. https://reviewboard.mozilla.org/r/164320/#review169664

(In reply to Hiroyuki Ikezoe (:hiro) from comment #6) > Comment on attachment 8893272 [details] > Bug 1386963 - Part 1: make paint-order animatable. > > https://reviewboard.mozilla.org/r/164318/#review169648 > > ::: servo/components/style/properties/gecko.mako.rs:5087 > (Diff revision 1) > > + use self::longhands::paint_order::SpecifiedValue; > > + > > + if self.gecko.mPaintOrder == structs::NS_STYLE_PAINT_ORDER_NORMAL as u8 { > > + return SpecifiedValue(NORMAL); > > + } > > Use computed_value::T instead of SpecifiedValue. > > ::: servo/components/style/properties/gecko.mako.rs:5093 > (Diff revision 1) > > + > > + if self.gecko.mPaintOrder == structs::NS_STYLE_PAINT_ORDER_NORMAL as u8 { > > + return SpecifiedValue(NORMAL); > > + } > > + > > + let mask = (1 << structs::NS_STYLE_PAINT_ORDER_BITWIDTH) - 1; > > Can we define this as const u8? > > ::: servo/components/style/properties/gecko.mako.rs:5105 > (Diff revision 1) > > + structs::NS_STYLE_PAINT_ORDER_MARKERS => MARKERS, > > + _ => unreachable!(), > > + }; > > + order |= value << (pos * SHIFT); > > + }; > > + SpecifiedValue(order) > > Use computed_value:T. Thanks, Hiro! Will fix and PR them.

Pushed by dakatsuka@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b10ab5ac752e Part 3: remove test fail annotations from meta in wpt. r=hiro