Closed
Bug 1387941
Opened 7 years ago
Closed 7 years ago
stylo: There are lots of failures of scroll-snap-{destination, coordinate} in test_transitions_per_property.html
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: boris, Assigned: hiro)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
We got lots of failures because scroll-snap-coordinate ans scroll-snap-destination should be discrete animation.
[1] Gecko: http://searchfox.org/mozilla-central/rev/b52285fffc13f36eca6b47de735d4e4403b3859e/layout/style/nsCSSPropList.h#3660,3673
[2] Servo: http://searchfox.org/mozilla-central/rev/b52285fffc13f36eca6b47de735d4e4403b3859e/servo/components/style/properties/longhand/box.mako.rs#719,728
Assignee | ||
Comment 1•7 years ago
|
||
Now I don't think it's worth making them animatable even if they are discrete type, since they have been dropped from the latest spec (See bug 1218265 comment 1). We should just ignore those properties in test_transitions_per_property.html for stylo?
Reporter | ||
Comment 2•7 years ago
|
||
(In reply to Hiroyuki Ikezoe (:hiro) from comment #1)
> Now I don't think it's worth making them animatable even if they are
> discrete type, since they have been dropped from the latest spec (See bug
> 1218265 comment 1). We should just ignore those properties in
> test_transitions_per_property.html for stylo?
Yes. I will skip all the failures in test_transitions_per_property.html for stylo in Bug 1292283. Use this bug to track this problem.
Comment 3•7 years ago
|
||
To make sure I understand - is the proposal here to ship a behavior change dropping support for animating these properties, since we plan to drop support for the properties themselves anyway? Do we consider this to be risky?
Updated•7 years ago
|
Flags: needinfo?(boris.chiou)
Reporter | ||
Updated•7 years ago
|
Blocks: css-scroll-snap
Flags: needinfo?(boris.chiou)
Comment hidden (obsolete) |
Reporter | ||
Comment 5•7 years ago
|
||
(In reply to Bobby Holley (:bholley) (busy with Stylo) from comment #3)
> To make sure I understand - is the proposal here to ship a behavior change
> dropping support for animating these properties, since we plan to drop
> support for the properties themselves anyway?
Yes, but not now. (Wait for Gecko's change.)
Do we consider this to be risky?
After removing these properties from Gecko. This wouldn't be risky.
I believe we will drop these properties in another bug for Gecko. After doing that, we can do the same thing for Servo in this (especially for animations) or other bugs. For now, I am not planning do anything because we have to wait Gecko's change. Currently, we skip the tests of these two properties for Servo in test_transitions_per_property.html, so this bug wouldn't affect Bug 1320841.
Assignee | ||
Comment 6•7 years ago
|
||
Though I think the behavior change (these properties are discrete animation on gecko but normal animation on stylo) is pretty low risk since I guess there are not so many sites that uses those properties and even less animation.
That's said, I don't think we should take much time for this issue. So, just make those properties as discrete on stylo too!
Comment hidden (mozreview-request) |
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8896835 [details]
Bug 1387941 - Make scroll-snap-{coordinate, destination} discrete animation.
https://reviewboard.mozilla.org/r/168132/#review173286
Attachment #8896835 -
Flags: review?(dakatsuka) → review+
Reporter | ||
Updated•7 years ago
|
Assignee: nobody → hikezoe
Assignee | ||
Comment 9•7 years ago
|
||
Assignee | ||
Comment 10•7 years ago
|
||
Comment hidden (mozreview-request) |
Comment 12•7 years ago
|
||
Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0c374dbcd5c6
Make scroll-snap-{coordinate, destination} discrete animation. r=daisuke
Comment 13•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•