Closed
Bug 1388391
Opened 7 years ago
Closed 7 years ago
Track DOMError usage with telemetry
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: ayg, Assigned: ayg)
References
Details
Attachments
(1 file)
We want to get rid of DOMError (bug 1120178). Let's see if it's used infrequently enough. We should track calls to the constructor, which will throw if removed; and to .name and .message, because those behave differently for DOMException.
The natural thing to track all this would be use counters, but those don't seem to currently support tracking constructor calls. Thus I'll block this on bug 1175033.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8896720 [details]
Bug 1388391 - Track DOMError usage with telemetry;
https://reviewboard.mozilla.org/r/168016/#review173416
::: dom/base/DOMError.cpp:72
(Diff revision 1)
> ErrorResult& aRv)
> {
> nsCOMPtr<nsPIDOMWindowInner> window = do_QueryInterface(aGlobal.GetAsSupports());
>
> + if (window) {
> + nsCOMPtr<nsIDocument> doc = window->GetDoc();
GetExtantDoc
Attachment #8896720 -
Flags: review?(bugs) → review+
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8896720 [details]
Bug 1388391 - Track DOMError usage with telemetry;
https://reviewboard.mozilla.org/r/168016/#review174178
This is [Category 1](https://wiki.mozilla.org/Firefox/Data_Collection#Data_Collection_Categories) data.
datareview+
Attachment #8896720 -
Flags: review?(francois) → review+
Comment hidden (mozreview-request) |
Pushed by ayg@aryeh.name:
https://hg.mozilla.org/integration/autoland/rev/417e576cfa1e
Track DOMError usage with telemetry; r=francois,smaug
Assignee | ||
Comment 6•7 years ago
|
||
I accidentally landed the version without the GetDoc -> GetExtantDoc fix. I'm trying to get someone to back it out or push a followup.
Backout by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/17c3cd3b69b6
Backed out changeset 417e576cfa1e on developers request
Pushed by ayg@aryeh.name:
https://hg.mozilla.org/integration/autoland/rev/79823f111dab
Track DOMError usage with telemetry; r=francois,smaug
Comment 9•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•