Closed
Bug 1391657
Opened 7 years ago
Closed 7 years ago
Mozilla Firefox Nightly 57.0a1 (2017-08-18) crashes in [@ mozilla::PrioritizedEventQueue<T>::EnablePrioritizationRunnable::Run ] with prioritized_input_events.enabled=true after landing patch from bug #1382922
Categories
(Core :: XPCOM, defect)
Tracking
()
VERIFIED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox55 | --- | unaffected |
firefox56 | --- | unaffected |
firefox57 | --- | verified |
People
(Reporter: Virtual, Assigned: billm)
References
Details
(Keywords: crash, nightly-community, regression)
Crash Data
Attachments
(1 file)
(deleted),
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
"Speedy" Regression window (mozilla-central)
Good:
https://ftp.mozilla.org/pub/firefox/nightly/2017/08/2017-08-17-10-01-32-mozilla-central/
Bad:
https://ftp.mozilla.org/pub/firefox/nightly/2017/08/2017-08-18-10-02-26-mozilla-central/
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=932388b8c22c9775264e543697ce918415db9e23&tochange=a6a1f5c1d971dbee67ba6eec7ead7902351ddca2
Probably caused by:
Kaspersky AV and some bug from pushlog above
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•7 years ago
|
Crash Signature: [@ mozilla::PrioritizedEventQueue<T>::EnablePrioritizationRunnable::Run ]
Comment 1•7 years ago
|
||
Bill, could this be a regression from bug 1382922 (which is in the regression window)? Or maybe just a signature change?
Flags: needinfo?(wmccloskey)
Comment 2•7 years ago
|
||
Can you reproduce this? What are the steps? Just install Kaspersky and load the browser?
Flags: needinfo?(Virtual)
Comment 3•7 years ago
|
||
I see 86 crashes (which is a lot!) but from only 3 installations.
Updated•7 years ago
|
Component: DOM: Content Processes → XPCOM
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Comment 4•7 years ago
|
||
STR:
1. Open "about:config"
2. Search for "prioritized_input_events.enabled"
3. Change it to "true" from "false"
4. Restart browser
and enjoy crashes even with opening new tab
Blocks: 1390044
Has Regression Range: --- → yes
Has STR: --- → yes
status-firefox55:
--- → unaffected
status-firefox56:
--- → unaffected
status-firefox-esr52:
--- → unaffected
Component: XPCOM → DOM: Content Processes
Flags: needinfo?(Virtual)
Summary: Mozilla Firefox Nightly 57.0a1 (2017-08-18) crashes in 57.0a1 [@ mozilla::PrioritizedEventQueue<T>::EnablePrioritizationRunnable::Run ] → Mozilla Firefox Nightly 57.0a1 (2017-08-18) crashes in [@ mozilla::PrioritizedEventQueue<T>::EnablePrioritizationRunnable::Run ]
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•7 years ago
|
Component: DOM: Content Processes → XPCOM
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•7 years ago
|
Blocks: 1351148
Keywords: regression
Comment 5•7 years ago
|
||
(In reply to Andrew McCreight [:mccr8] from comment #3)
> I see 86 crashes (which is a lot!) but from only 3 installations.
I guess that's my 3 profiles. Here is crash stats:
https://crash-stats.mozilla.com/report/index/bp-3f409935-b27f-453a-87fc-a070f0170818
Use STR from Comment 4.
I also reported this crash here: https://bugzilla.mozilla.org/show_bug.cgi?id=1390044#c1
Comment 6•7 years ago
|
||
Thanks. Alright, so this doesn't have anything to do with Kaspersky. I can also reproduce this. Warning: don't try to reproduce this in your main profile as it totally wrecks your tab state. ;)
Summary: Mozilla Firefox Nightly 57.0a1 (2017-08-18) crashes in [@ mozilla::PrioritizedEventQueue<T>::EnablePrioritizationRunnable::Run ] → Mozilla Firefox Nightly 57.0a1 (2017-08-18) crashes in [@ mozilla::PrioritizedEventQueue<T>::EnablePrioritizationRunnable::Run ] with prioritized_input_events.enabled=true
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•7 years ago
|
Summary: Mozilla Firefox Nightly 57.0a1 (2017-08-18) crashes in [@ mozilla::PrioritizedEventQueue<T>::EnablePrioritizationRunnable::Run ] with prioritized_input_events.enabled=true → Mozilla Firefox Nightly 57.0a1 crashes in [@ mozilla::PrioritizedEventQueue<T>::EnablePrioritizationRunnable::Run ] with input event queue enabled
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•7 years ago
|
Summary: Mozilla Firefox Nightly 57.0a1 crashes in [@ mozilla::PrioritizedEventQueue<T>::EnablePrioritizationRunnable::Run ] with input event queue enabled → Mozilla Firefox Nightly 57.0a1 crashes in [@ mozilla::PrioritizedEventQueue<T>::EnablePrioritizationRunnable::Run ] with prioritized_input_events.enabled=true
Assignee | ||
Comment 7•7 years ago
|
||
Oops. Forgot to initialize a member.
Assignee: nobody → wmccloskey
Flags: needinfo?(wmccloskey)
Attachment #8898971 -
Flags: review?(continuation)
Comment 8•7 years ago
|
||
Comment on attachment 8898971 [details] [diff] [review]
patch
Review of attachment 8898971 [details] [diff] [review]:
-----------------------------------------------------------------
::: xpcom/threads/PrioritizedEventQueue.cpp
@@ +304,5 @@
> {
> public:
> explicit EnablePrioritizationRunnable(PrioritizedEventQueue<InnerQueueT>* aQueue)
> : Runnable("EnablePrioritizationRunnable")
> + , mQueue(aQueue)
I guess this queue is some kind of global data structure so you don't have to worry about the runnable outliving the queue while holding this weak pointer?
Attachment #8898971 -
Flags: review?(continuation) → review+
Assignee | ||
Comment 9•7 years ago
|
||
(In reply to Andrew McCreight [:mccr8] from comment #8)
> I guess this queue is some kind of global data structure so you don't have
> to worry about the runnable outliving the queue while holding this weak
> pointer?
It's the event queue. If we don't have that anymore, then we can't be processing events. So the runnable wouldn't have run. I'll add a comment.
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Updated•7 years ago
|
Blocks: 1382922
Status: NEW → ASSIGNED
OS: Windows 8.1 → All
Summary: Mozilla Firefox Nightly 57.0a1 crashes in [@ mozilla::PrioritizedEventQueue<T>::EnablePrioritizationRunnable::Run ] with prioritized_input_events.enabled=true → Mozilla Firefox Nightly 57.0a1 (2017-08-18) crashes in [@ mozilla::PrioritizedEventQueue<T>::EnablePrioritizationRunnable::Run ] with prioritized_input_events.enabled=true after landing patch from bug #1382922
Comment 10•7 years ago
|
||
Pushed by wmccloskey@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6fa486012b34
Fix missing member initialization for input prioritization (r=mccr8)
Comment 11•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Comment 12•7 years ago
|
||
No sign of this crash in Nightly 20170820100343!
Status: RESOLVED → VERIFIED
Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)
Reporter
|
||
Comment 13•7 years ago
|
||
I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 57.0a1 (2017-08-20), so I'm marking this bug as VERIFIED. Thank you very much! \o/
You need to log in
before you can comment on or make changes to this bug.
Description
•