Open Bug 1404982 Opened 7 years ago Updated 5 years ago

Rework WebRTC AEC logging

Categories

(Core :: WebRTC: Audio/Video, enhancement, P2)

enhancement

Tracking

()

People

(Reporter: padenot, Unassigned)

References

(Blocks 3 open bugs)

Details

Implement in-memory AEC data buffering + blob downloading. The goal here is to be able to get AEC log from about:webrtc, by downloading a zip of wav/opus files (not raw, it’s just lazy to do that). This works around sandboxing and is a better UX anyways. I want to be able to get AEC reports from the field easily and reliably. This is easy to implement for a DOM hacker. Let’s be honest with ourselves, logging will stay broken for a while on important platforms (Windows, OSX), and asking people to set env variables and writing files directly to the file system is a terrible idea, both to get the logs (i.e. people will do the complicated steps we tell them) and for security (having something that fopen/fwrite in the middle of the code is scary). Because we now have much more modern, integrated code for all that, it’s easier to do.
Quite important to be able to diagnose quickly when doing modifications.
Rank: 20
Blocks: 1414165
Summary: Rework WebRTC logging → Rework WebRTC AEC logging

I could not find any documentation on how to make sense out of AEC debug logs. I am trying to figure out if AEC is working for my use case or not. In chrome, we get various audio files, input, reverse, output etc.

Can someone please point me to an appropriate document or maybe give instructions here?

Ok we're here again. It's still blocked by the sandbox, also I hit https://crash-stats.mozilla.org/report/index/86af7ba6-286b-4c00-bd9f-6ecc20200406, and it's still outputting nonsensical files where you have to know the characteristics, etc.

We need a more solid solution, based on https://searchfox.org/mozilla-central/source/dom/media/WavDumper.h probably. I assume there is no filesystem access, so we need to rework it to allow writing in a buffer, and then offer to "download" a zip.

Nils, this is blocking investigation of bug 1627313, that seem important.

Flags: needinfo?(drno)
Severity: normal → S3
Priority: P3 → P2

Bumping priority, since it sounds important, and good echo cancellation is a really important quality-of-life thing.

Flags: needinfo?(drno)
You need to log in before you can comment on or make changes to this bug.