Closed Bug 1407395 Opened 7 years ago Closed 7 years ago

Guard against empty defines entry when generating langpack manifest

Categories

(Core :: Internationalization, defect)

Product:
Core
Component:
Internationalization
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla58
Tracking Flags:
Tracking Status
firefox58 --- fixed

People

(Reporter: zbraniecki, Assigned: zbraniecki)

References

Details

Attachments

(1 file)

Bug 1407395 - Guard against empty defines entry when generating langpack manifest.
(deleted), text/x-review-board-request
Pike
: review+
Details
Langpack manifest is generated using defines, which, when missing, show up key instead of empty string or None. This pops up in finnish build
Assignee: nobody → gandalf
Blocks: 1395363
Status: NEW → ASSIGNED
Comment on attachment 8917124 [details] Bug 1407395 - Guard against empty defines entry when generating langpack manifest. https://reviewboard.mozilla.org/r/188130/#review193316
Attachment #8917124 - Flags: review?(l10n) → review+
Pushed by zbraniecki@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c1cd0fb9736b Guard against empty defines entry when generating langpack manifest. r=Pike
https://hg.mozilla.org/mozilla-central/rev/c1cd0fb9736b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: