Closed
Bug 1409162
Opened 7 years ago
Closed 7 years ago
Speed up nsTableColFrame::GetColIndex
Categories
(Core :: Layout: Tables, enhancement, P3)
Tracking
()
RESOLVED
FIXED
mozilla58
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
Details
Attachments
(1 file, 2 obsolete files)
|
(deleted),
patch
|
Details | Diff | Splinter Review |
We can devirtualize it, remove some branches, etc.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8919038 -
Flags: review?(mats)
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•7 years ago
|
||
Attachment #8919067 -
Flags: review?(mats)
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8919038 -
Attachment is obsolete: true
Attachment #8919038 -
Flags: review?(mats)
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8919067 [details] [diff] [review]
Make nsTableCellFrame::GetColIndex/GetRowIndex faster
>+ // XXXbz Do we really need to query, or can we assume we have a cellframe
>+ // here?
>+ return do_QueryFrame(mContent->GetPrimaryFrame());
This is a11y code, so I don't think we need to micro-optimize the code
to the level where do_QueryFrame would matter. (Note that in the common
case here do_QueryFrame is non-virtual anyway (since bug 1364815)).
So I suggest you leave out this code comment.
Attachment #8919067 -
Flags: review?(mats) → review+
|
|
Assignee | |
Comment 4•7 years ago
|
||
Attachment #8919104 -
Flags: review?(mats)
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8919067 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•7 years ago
|
Attachment #8919104 -
Flags: review?(mats)
|
||
Updated•7 years ago
|
status-firefox57:
--- → wontfix
Priority: -- → P3
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ccbc0a2df1d
Make nsTableCellFrame::GetColIndex/GetRowIndex faster. r=mats
|
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•