Closed
Bug 1409916
Opened 7 years ago
Closed 7 years ago
[e10s a11y] Eliminate pointless cross-proc call for IA2_2::attribute
Categories
(Core :: Disability Access APIs, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: Jamie, Assigned: Jamie)
References
Details
(Whiteboard: [aes+])
Attachments
(1 file)
As noted in bug 1363595 comment 24, IAccessible2_2::get_attribute is not implemented yet in Gecko. However, the handler still passes this through, thus resulting in a pointless cross-process call. We should just return E_NOTIMPL in the handler for this method. JAWS calls this quite a bit, and the more cross-proc calls we can eliminate, the better for perf.
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 2•7 years ago
|
||
Forgot to note that this depends on the patches from bug 1363595.
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8919944 [details]
Bug 1409916: Eliminate pointless cross-process call for IAccessible2_2::get_attribute.
https://reviewboard.mozilla.org/r/190888/#review198740
Attachment #8919944 -
Flags: review?(aklotz) → review+
|
||
Updated•7 years ago
|
Whiteboard: [aes+]
|
|
||
Comment 4•7 years ago
|
||
(I'm going to hold off adding aes+ to the rest of the cache perf work pending discussion how we want to track it all)
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/681b41afb3ee
Eliminate pointless cross-process call for IAccessible2_2::get_attribute. r=aklotz
Keywords: checkin-needed
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•