Closed
Bug 1415345
Opened 7 years ago
Closed 7 years ago
FxAccountsStorageManager#getAccountData 'name' is not defined
Categories
(Firefox :: Firefox Accounts, defect)
Firefox
Firefox Accounts
Tracking
()
RESOLVED
FIXED
Firefox 58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
I picked this up whilst starting to looking into better linting of jsms in bug 1369722. http://searchfox.org/mozilla-central/source/services/fxaccounts/FxAccountsStorage.jsm#196 ```throw new Error("unexpected field '" + name + "'");``` name is undefined, so this won't report the right thing. As it is only used in an error case, I believe there won't be adverse effects, but we should fix it anyway to make lint happy.
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8926133 [details] Bug 1415345 - Fix undefined variable in error message in FxAccountsStorageManager#getAccountData. https://reviewboard.mozilla.org/r/197374/#review203158 Thanks!
Attachment #8926133 -
Flags: review?(markh) → review+
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/798de42346d1 Fix undefined variable in error message in FxAccountsStorageManager#getAccountData. r=markh
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/798de42346d1
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
|
||
Updated•7 years ago
|
Product: Core → Firefox
|
||
Updated•7 years ago
|
Target Milestone: mozilla58 → Firefox 58
You need to log in
before you can comment on or make changes to this bug.
Description
•