Closed
Bug 1416968
Opened 7 years ago
Closed 7 years ago
building with --enable-official-branding is broken with: ValueError: Object directory paths are not allowed
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(firefox59 fixed)
RESOLVED
FIXED
mozilla59
Tracking | Status | |
---|---|---|
firefox59 | --- | fixed |
People
(Reporter: dbaron, Assigned: dbaron)
References
Details
Attachments
(1 file)
(deleted),
patch
|
m_kato
:
review+
|
Details | Diff | Splinter Review |
Building Firefox with --enable-official-branding currently yields the following error:
> 0:13.24 Reticulating splines...
> 0:25.08 Traceback (most recent call last):
> 0:25.08 File "/home/dbaron/builds/mozilla-central/mozilla/configure.py", line 127, in <module>
> 0:25.08 sys.exit(main(sys.argv))
> 0:25.08 File "/home/dbaron/builds/mozilla-central/mozilla/configure.py", line 34, in main
> 0:25.08 return config_status(config)
> 0:25.08 File "/home/dbaron/builds/mozilla-central/mozilla/configure.py", line 122, in config_status
> 0:25.08 return config_status(args=[], **encode(sanitized_config, encoding))
> 0:25.08 File "/home/dbaron/builds/mozilla-central/mozilla/python/mozbuild/mozbuild/config_status.py", line 150, in config_status
> 0:25.08 the_backend.consume(definitions)
> 0:25.08 File "/home/dbaron/builds/mozilla-central/mozilla/python/mozbuild/mozbuild/backend/base.py", line 128, in consume
> 0:25.08 if (not self.consume_object(obj) and
> 0:25.08 File "/home/dbaron/builds/mozilla-central/mozilla/python/mozbuild/mozbuild/backend/fastermake.py", line 57, in consume_object
> 0:25.08 self._consume_jar_manifest(obj)
> 0:25.08 File "/home/dbaron/builds/mozilla-central/mozilla/python/mozbuild/mozbuild/backend/common.py", line 504, in _consume_jar_manifest
> 0:25.08 (src, output_basename))
> 0:25.08 File "/home/dbaron/builds/mozilla-central/mozilla/python/mozbuild/mozbuild/frontend/context.py", line 551, in __call__
> 0:25.08 return super(PathMeta, cls).__call__(context, value)
> 0:25.08 File "/home/dbaron/builds/mozilla-central/mozilla/python/mozbuild/mozbuild/frontend/context.py", line 662, in __init__
> 0:25.08 super(RenamedSourcePath, self).__init__(context, source)
> 0:25.08 File "/home/dbaron/builds/mozilla-central/mozilla/python/mozbuild/mozbuild/frontend/context.py", line 621, in __init__
> 0:25.08 raise ValueError('Object directory paths are not allowed')
> 0:25.08 ValueError: Object directory paths are not allowed
> 0:25.69 *** Fix above errors and then restart with\
> 0:25.69 "/usr/bin/make -f client.mk build"
> 0:25.69 /home/dbaron/builds/mozilla-central/mozilla/client.mk:246: recipe for target 'configure' failed
> 0:25.69 make[1]: *** [configure] Error 1
Assignee | ||
Comment 1•7 years ago
|
||
Removing the parenthetical bits at the end of browser/branding/official/content/jar.mn avoids the error. These were modified recently in bug 1415014.
Assignee | ||
Comment 2•7 years ago
|
||
The path in question is "!../mozicon128.png".
Assignee | ||
Comment 3•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Flags: needinfo?(m_kato)
Assignee | ||
Updated•7 years ago
|
Summary: building with --enable-official-branding is broken → building with --enable-official-branding is broken with: ValueError: Object directory paths are not allowed
Updated•7 years ago
|
Attachment #8928061 -
Flags: review+
Assignee | ||
Comment 5•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/611e36cc135a7e6f5749ddb8ec09238bfa8be4d2
Bug 1416968 - Fix path to unbreak --enable-official-branding build. r=m_kato
Comment 6•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Updated•7 years ago
|
Assignee: nobody → dbaron
Assignee | ||
Comment 7•7 years ago
|
||
I filed bug 1417180 on getting a better error message here.
Updated•7 years ago
|
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•