Closed
Bug 1418130
Opened 7 years ago
Closed 7 years ago
Fix favicon link, default tippytop and bug fixes to Activity Stream
Categories
(Firefox :: New Tab Page, defect, P1)
Firefox
New Tab Page
Tracking
()
RESOLVED
FIXED
Firefox 59
People
(Reporter: dmosedale, Assigned: Mardak)
References
Details
(Whiteboard: [export])
User Story
Attachments
(3 files)
|
Bug 1418130 - add prop-types license and remove activity-stream from list of reselect license users,
(deleted),
text/x-review-board-request
|
gerv
:
review+
|
Details |
|
(deleted),
text/x-review-board-request
|
k88hudson
:
review+
|
Details |
|
Bug 1418130 - add prop-types license and remove activity-stream from list of reselect license users,
(deleted),
text/x-review-board-request
|
gerv
:
review+
|
Details |
This is a bug intended to be used for the _next_ export to github.
That export will include the new "prop-types" package and license, as that package contains code that was original part of React, and is now split out into its own MIT-licensed package (see https://github.com/mozilla/activity-stream/issues/3836 and the associated pull request for details).
I'm going to attache the necessary license.html patch to this bug and get it reviewed now, so that it can be landed with the next uplift.
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8929234 [details]
Bug 1418130 - add prop-types license and remove activity-stream from list of reselect license users,
https://reviewboard.mozilla.org/r/200506/#review205660
Attachment #8929234 -
Flags: review?(gerv) → review+
|
||
Updated•7 years ago
|
status-firefox57:
--- → wontfix
status-firefox58:
--- → affected
|
|
||
Comment 3•7 years ago
|
||
[Tracking Requested - why for this release]: this needs to be included in next 58 beta uplift
tracking-firefox58:
--- → ?
|
|
||
Updated•7 years ago
|
Priority: -- → P1
|
|
||
Updated•7 years ago
|
tracking-firefox58:
? → ---
|
|
||
Updated•7 years ago
|
status-firefox59:
--- → affected
|
Assignee | |
Updated•7 years ago
|
|
Reporter | |
Updated•7 years ago
|
Summary: export from github with react 16 → export from github with (at least) new proptypes
|
|
Assignee | |
Updated•7 years ago
|
|
|
Assignee | |
Comment 4•7 years ago
|
||
Like the previous export, this does not include https://github.com/mozilla/activity-stream/pull/3875 as it's still pending data review in https://github.com/mozilla/activity-stream/pull/3877
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 7•7 years ago
|
||
Meh.
gerv, sorry about the re-request-r? MozReview couldn't associate the two commits together, so I had to re-push, and it isn't smart enough to carry over your r+ for attachment 8929234 [details]
|
|
||
Updated•7 years ago
|
Attachment #8935569 -
Flags: review?(gerv) → review+
|
|
Assignee | |
Updated•7 years ago
|
User Story: (updated)
Summary: Fix tippytop site_icons, favicon link and bug fixes to Activity Stream → Fix favicon link, default tippytop and bug fixes to Activity Stream
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 10•7 years ago
|
||
wow.. mozreview...
|
|
Assignee | |
Comment 11•7 years ago
|
||
Updated with bug 1424292 and bug 1423506 landing separately as those are potentially for 58 uplift.
Depends on: 1424292
|
|
||
Updated•7 years ago
|
Attachment #8935569 -
Flags: review?(gerv) → review+
|
||
Comment 12•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8935548 [details]
Bug 1418130 - Fix favicon link, default tippytop and bug fixes to Activity Stream.
https://reviewboard.mozilla.org/r/206422/#review213012
Looks good
Attachment #8935548 -
Flags: review?(khudson) → review+
|
||
Comment 13•7 years ago
|
||
Pushed by edilee@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/75910829e890
Fix favicon link, default tippytop and bug fixes to Activity Stream. r=k88hudson
https://hg.mozilla.org/integration/mozilla-inbound/rev/28f5404cc95e
add prop-types license and remove activity-stream from list of reselect license users, r=gerv
|
||
Comment 14•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/75910829e890
https://hg.mozilla.org/mozilla-central/rev/28f5404cc95e
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 59
|
|
||
Comment 15•7 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Updated•6 years ago
|
Whiteboard: [export]
|
||
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•