Open Bug 1421651 Opened 7 years ago Updated 1 year ago

Remove docshell markers

Categories

(Core :: Gecko Profiler, enhancement, P3)

Product:
Core
Component:
Gecko Profiler
Type:
enhancement

Tracking

()

Status:
REOPENED

People

(Reporter: gregtatum, Assigned: aabh, NeedInfo)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Whiteboard: [fxp])

Attachments

(3 files, 7 obsolete files)

Bug 1421651 - Remove obseleted timeline and TimelineMarker code r=canaltinova
(deleted), text/x-phabricator-request
Details
Bug 1421651 - Add counter API for animation triggered restyles r?emilio
(deleted), text/x-phabricator-request
Details
Bug 1421651 - Integrate animation triggered restyle counter into tests r?emilio
(deleted), text/x-phabricator-request
Details
The docshell markers need to be removed after we've migrated to the new performance recording panel. This is the bug to track that work.
Blocks: devtools-perfhtml
Priority: -- → P3
Blocks: 1278588
Greg, can you add some background about why we want to do this?
Flags: needinfo?(gtatum)
docshell markers are collected via references to the docshell. This is really nice because it's easy to associate a given event with a particular website. The DevTools performance tool uses these, and created a competing implementation with the Gecko Profiler markers. It would be nice to unify these approaches and only have one implementation of markers. https://searchfox.org/mozilla-central/source/docshell/base/timeline We might need to have a broader conversation to figure out exactly how to accomplish this, as the docshell markers are nice in that they can be targeted at one particular docshell, while the Gecko Profiler ones are associated per content process. It would be nice to do some investigation on figuring out how to get some kind of docshell ID in the marker payloads of the Gecko Profiles. See bug 1417976.
Depends on: 1417976
Flags: needinfo?(gtatum)
Product: Firefox → DevTools

The Firefox Profiler markers now have information about the content they relate to. I believe we can remove docshell markers now as I don't think there's any consumer left.

Of course it would be good while doing that that we also have existing equivalent Firefox Profiler markers.

Severity: normal → S3
Assignee: nobody → abrouwersharries

This patch removes the old docshell timeline AutoTimelineMarker from the codebase and replaces it with an equivalent Gecko profiler marker. This patch also fixes Bug 1834143, which is a subset of 1421651.

Depends on D184217

Depends on D185176

Depends on D185177

Depends on D185178

Depends on D185179

Depends on D185180

Attachment #9345041 - Attachment description: Bug 1421651 - Remove AutoTimelineMarker and references in docs r=canaltinova → Bug 1421651 - Remove obseleted timeline and TimelineMarker code r=canaltinova
Attachment #9346966 - Attachment is obsolete: true
Attachment #9346965 - Attachment is obsolete: true
Attachment #9346964 - Attachment is obsolete: true
Attachment #9346963 - Attachment is obsolete: true
Attachment #9346962 - Attachment is obsolete: true
Attachment #9346961 - Attachment is obsolete: true
Attachment #9346960 - Attachment is obsolete: true
Whiteboard: [fxp]
Component: Performance Tools (Profiler/Timeline) → Gecko Profiler
Product: DevTools → Core

This patch adds an API to count the number of restyles triggered by animations. This API will replace the existing timeline marker based testing of the animation/restyle system.

This commits integrates the new animation triggered restyle counter into the existing tests to ensure that the counter matches the expected marker count.

Depends on D186714

Pushed by abrouwersharries@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ac079a84284e Add counter API for animation triggered restyles r=emilio
Pushed by abrouwersharries@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/073e03319881 Integrate animation triggered restyle counter into tests r=emilio

https://hg.mozilla.org/mozilla-central/rev/ac079a84284e

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox118: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 118 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: