Several corruptions on http://keithclark.co.uk/labs/css-fps/nojs/
Categories
(Core :: Graphics: WebRender, defect, P5)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr52 | --- | unaffected |
firefox57 | --- | unaffected |
firefox58 | --- | unaffected |
firefox59 | --- | unaffected |
firefox62 | --- | disabled |
firefox63 | --- | disabled |
firefox64 | --- | disabled |
People
(Reporter: linuxhippy, Assigned: kvark, NeedInfo)
References
(Blocks 1 open bug, )
Details
(Keywords: correctness, nightly-community, regression, Whiteboard: [wr-reserve])
Attachments
(4 files)
Comment 1•7 years ago
|
||
Comment 2•7 years ago
|
||
Updated•7 years ago
|
Updated•7 years ago
|
Updated•7 years ago
|
Updated•7 years ago
|
Updated•7 years ago
|
Updated•7 years ago
|
Reporter | ||
Comment 3•7 years ago
|
||
Comment 4•7 years ago
|
||
Comment 5•6 years ago
|
||
Comment 6•6 years ago
|
||
Comment 7•6 years ago
|
||
Comment 8•6 years ago
|
||
Updated•6 years ago
|
Updated•6 years ago
|
Comment 9•6 years ago
|
||
Comment 10•6 years ago
|
||
Assignee | ||
Comment 11•6 years ago
|
||
Comment 12•6 years ago
|
||
Reporter | ||
Comment 14•6 years ago
|
||
Reporter | ||
Comment 15•6 years ago
|
||
Comment 16•6 years ago
|
||
Reporter | ||
Comment 17•6 years ago
|
||
Assignee | ||
Comment 18•6 years ago
|
||
The demo is now rendering correctly. It is crushing about 20 seconds in, but there is a separate bug - https://bugzilla.mozilla.org/show_bug.cgi?id=1522015 . This is not about visual quality any more.
Reporter | ||
Comment 19•6 years ago
|
||
Reporter | ||
Comment 20•6 years ago
|
||
- it is better, but I still get artifacts. please re-open.
- the WebRender crashes reported (ressource leaks) are not what bug 1522015 is about.
Updated•6 years ago
|
Updated•6 years ago
|
Comment 21•6 years ago
|
||
Just wanted to chime in here and mention that on dev channel (66.0b10 (64-bit)) w/a geforce rtx 2080ti I get massive artifacts in both the interactive and automated demos for css-fps, and the entire browser chrome periodically turns solid white. The interactive demo also causes frequent hangs. The most significant artifact is that the perspective texturing on various elements is hosed, but sometimes things flicker in and out of visibility entirely.
This appears to be true with and without WebRender, somehow? It may be that about:support is lying about what backend is being used to do layout and rasterization for the page. I checked about:support before testing and with webrender on and off I see the same artifacts.
Assignee | ||
Comment 22•6 years ago
|
||
We'll double check the behavior on Windows/GeForce. It's rather strange that you'd get the same artifacts regardless of Webrender. Are you sure it reported D3D11 compositor when you disabled WR? Did you restart the browser upon flipping that pref?
Comment 23•5 years ago
|
||
At least on my system (Ubuntu 19.04+Ivy Bridge, FF 71.0a1 (2019-09-18) (64-bit) from PPA), it no longer renders incorrectly. Still drops to about 2FPS in many parts, but now at least some parts actually render with decent FPS.
Comment 24•5 years ago
|
||
Same for me when I recently tested this on an AMD 5700 GPU - no artifacts, very smooth 60 fps in most parts, but a few places where it drops to single digit fps.
The 5700 GPU is incredibly powerful, so we must be doing something very wrong to cause those frame drops. I didn't check whether it was a CPU or GPU issue. I wonder if we hit some kind of edge case in plane-split and generate thousands of splits, or something like that. Need to investigate further to see what this remaining issue is.
Assignee | ||
Comment 25•5 years ago
|
||
Glenn, this may happen if we end up with too many draw calls, since a powerful GPU will not help with the driver overhead. Part of the reason for many draw calls could be that we have multiple batch regions per tile. Regardless, I think we should be looking at the performance in a different issue.
Clemens, could you confirm if you are still seeing the issue?
Comment 26•5 years ago
|
||
Yep - agreed we should move the performance bits to a different bug.
FWIW, I just tested again - draw call count never exceeds 200, it's often < 100 when the single FPS drops occur. Interestingly, according to the profiler, the CPU threads (backend + renderer) and GPU all remain well under 16 ms / frame. So I wonder if it's actually something else in Gecko that causes the slowdown in these parts, or perhaps something that is not being reported by the WR profiler somehow.
Comment 27•5 years ago
|
||
I can confirm, that this has been rendering correctly for a while, on both my MacBook Pro (with AMD RX 560) and Desktop (Win10 + 1070 GTX). The FPS issues of-course are still there
Comment 28•5 years ago
|
||
Retested on roughly the same config and can confirm for me that it mostly works great now and has no glitches. There are nasty frame drops later in the demo but I'm sure those are just driver / stack corner cases, so this is at least a dramatic improvement.
Comment 29•5 years ago
|
||
Bugbug thinks this bug is a regression, but please revert this change in case of error.
Comment 30•5 years ago
|
||
Can someone close this? No one has reported any correctness issues here in a month, so things are probably fine.
Updated•5 years ago
|
Updated•5 years ago
|
Description
•