Create Talos configuration for "emulate XUL with flex"
Categories
(Testing :: Talos, enhancement)
Tracking
(firefox60 fixed)
Tracking | Status | |
---|---|---|
firefox60 | --- | fixed |
People
(Reporter: dholbert, Assigned: bgrins)
References
Details
(Whiteboard: [PI:January])
Attachments
(2 files)
Bug 1425330 - Part 1 - set up talos configurations for tart and ts_paint with XUL flexbox emulation;
(deleted),
text/x-review-board-request
|
rwood
:
review+
|
Details |
(deleted),
text/x-review-board-request
|
rwood
:
review+
|
Details |
Reporter | ||
Comment 1•7 years ago
|
||
Comment 2•7 years ago
|
||
Updated•7 years ago
|
Assignee | ||
Comment 3•7 years ago
|
||
Comment 4•7 years ago
|
||
Comment 5•7 years ago
|
||
Assignee | ||
Comment 6•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 9•7 years ago
|
||
Assignee | ||
Comment 10•7 years ago
|
||
Comment 11•7 years ago
|
||
mozreview-review |
Comment 12•7 years ago
|
||
Comment 13•7 years ago
|
||
mozreview-review |
Comment 14•7 years ago
|
||
Comment 15•7 years ago
|
||
bugherder |
Assignee | ||
Comment 16•7 years ago
|
||
Comment 17•6 years ago
|
||
Today, Talos(flex) is still running as tier 3 on mozilla-central. All recent runs are green, so these could probably run as tier 2 or tier 1, where they would not be hidden and would get the benefits of sheriffing. Could/should they be promoted to tier 1 or 2? (Or, if results are not needed, should they be disabled on mozilla-central, or entirely?) Just let me know -- I'm happy to land patches if needed.
Assignee | ||
Comment 18•6 years ago
|
||
(In reply to Geoff Brown [:gbrown] from comment #17)
Today, Talos(flex) is still running as tier 3 on mozilla-central. All recent runs are green, so these could probably run as tier 2 or tier 1, where they would not be hidden and would get the benefits of sheriffing. Could/should they be promoted to tier 1 or 2? (Or, if results are not needed, should they be disabled on mozilla-central, or entirely?) Just let me know -- I'm happy to land patches if needed.
That's a good question. We are hoping to improve the numbers during this quarter as a result of ongoing flexbox perf work, so definitely don't want them disabled. I'm not sure if we want them to be sheriffed since I don't know that regressions would be actionable at least until stuff like https://bugzilla.mozilla.org/show_bug.cgi?id=1493962 lands and we are a bit greener on mochitests. My feeling is maybe start sheriffing it when we see a path forward for shipping CSS flex emulation? Although if we don't have other talos tests tracking CSS flexbox perf perhaps it would be a useful proxy for that. Forward to Daniel for another opinion.
Updated•6 years ago
|
Reporter | ||
Comment 19•6 years ago
|
||
Sorry for the delay -- the needinfo slipped off my radar.
I agree with bgrins.
- sheriffing doesn't seem necessary at the moment.
- We should keep this enabled as tier3 on mozilla-central (not on any other trees though).
- If it's occupying a lot of CPU time, we could bump it to once per day or something in the near term -- but probably not less frequent than that. I'd like to have ~continuous data to catch regressions & demonstrate improvements here, as we get closer to having flex/XUL emulation being a viable option.
Comment 20•6 years ago
|
||
OK, thanks. I don't have concerns regarding CPU time / won't make any changes at this time.
Description
•