Closed
Bug 1426464
Opened 7 years ago
Closed 7 years ago
Show (edit) icon on hovering site placeholder
Categories
(Firefox :: New Tab Page, enhancement, P1)
Firefox
New Tab Page
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox59 | --- | verified |
People
(Reporter: Mardak, Assigned: rrosario)
References
Details
(Keywords: uiwanted)
Attachments
(3 files)
Show Edit for Empty Topsites.png
bryan will provide designs, but basically allow a context-menu-button that shows the edit icon instead of the usual meatball for placeholders. Similarly, the edit mode should show the single edit icon instead of the triple icon on hover.
r1cky, can you take this?
Flags: needinfo?(bbell)
The basic idea is that blank topsites need to have the option to edit them manually.
Flags: needinfo?(bbell)
|
||
Comment 2•7 years ago
|
||
|
||
Comment 3•7 years ago
|
||
Commits pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/de0006bc728b1df05c0cadaf2b5852e5977da3fb
Fix Bug 1426464 - edit button for Top Site placeholders
https://github.com/mozilla/activity-stream/commit/f0f1daa8e0d1155138025b0a13d3e7a6a3cd73da
Merge pull request #3911 from rlr/bug1426464/placeholder-hover
Fix Bug 1426464 - edit button for Top Site placeholders
|
|
||
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
Reporter | |
Updated•7 years ago
|
Severity: normal → enhancement
|
|
||
Comment 4•7 years ago
|
||
|
|
||
Comment 5•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/activity-stream
https://github.com/mozilla/activity-stream/commit/8467c6d92b104824f17fa5336dcd00aa28ad8078
chore(topsites): Refactor various parts of editing (#3913)
Followup fixes for Bug 1426464
|
|
Reporter | |
Comment 6•7 years ago
|
||
Target Milestone: --- → Firefox 59
|
||
Comment 7•7 years ago
|
||
I have verified that the Edit button appears when empty placeholders are hovered on the latest Nightly 59.0a1 (Build ID 20180110100224) on Arch Linux x64, Ubuntu 16.04 x86, Mac 10.12.6 and Windows 10 x64.
Status: RESOLVED → VERIFIED
|
||
Updated•5 years ago
|
Component: Activity Streams: Newtab → New Tab Page
You need to log in
before you can comment on or make changes to this bug.
Description
•