Closed
Bug 1428443
Opened 7 years ago
Closed 7 years ago
Allow panels to override picker functionality when they are active.
Categories
(DevTools :: Framework, enhancement, P2)
Tracking
(firefox60 fixed)
RESOLVED
FIXED
Firefox 60
| Tracking | Status | |
|---|---|---|
| firefox60 | --- | fixed |
People
(Reporter: yzen, Assigned: yzen)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
pbro
:
review+
|
Details | Diff | Splinter Review |
Use case:
Inspector panel highlights/picks accessible objects and not DOM nodes. They do not have a box model and might have different bounds from DOM nodes. Picker in this case would need to work with objects other than DOM nodes.
|
||
Updated•7 years ago
|
Severity: normal → enhancement
Priority: -- → P2
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8947824 -
Flags: review?(pbrosset)
|
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8947824 [details] [diff] [review]
1428443 patch
Review of attachment 8947824 [details] [diff] [review]:
-----------------------------------------------------------------
::: devtools/client/framework/toolbox.js
@@ +1423,5 @@
> +
> + if (currentPanel && currentPanel.updatePickerButton) {
> + currentPanel.updatePickerButton();
> + } else {
> + button.description = L10N.getStr("pickButton.tooltip");
Please insert a comment before this line that says something like "if the current panel doesn't define a custom updatePickerButton, revert the button to its default state".
Attachment #8947824 -
Flags: review?(pbrosset) → review+
Pushed by yura.zenevich@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e0ac728caeaa
allow panels to override picker functionality when they are active. r=pbro
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox60:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 60
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•