It's only there for add-on compat. You will need to remove the entry in browser/base/content/test/static/browser_all_files_referenced.js as well.

Please assign this bug to me. also please find the patch and review it. Thanks

Comment on attachment 8962932 [details] [diff] [review] Bug1429394 Review of attachment 8962932 [details] [diff] [review]: ----------------------------------------------------------------- You need to remove the file itself: toolkit/locales/generic/chrome/global/brand.dtd `hg rm toolkit/locales/generic/chrome/global/brand.dtd` ::: browser/base/content/test/static/browser_all_files_referenced.js @@ +52,4 @@ > > // Add-on compat > {file: "chrome://global/content/XPCNativeWrapper.js"}, > + Please remove the leading whitespace

Please review.

Comment on attachment 8963018 [details] [diff] [review] Bug1429394 Review of attachment 8963018 [details] [diff] [review]: ----------------------------------------------------------------- With the trailing whitespace fixed, this looks fine to me, thanks! ::: browser/base/content/test/static/browser_all_files_referenced.js @@ +52,4 @@ > > // Add-on compat > {file: "chrome://global/content/XPCNativeWrapper.js"}, > + Nit: trailing whitespace here

but please someone assign this bug to me :P I worked on this :(

Have you had the time to address Mike's comment ?

I will submit the patch soon. I was traveling.

Please review.

Looks good, thanks!

Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/dcd8ba6a9028 Remove toolkit/locales/generic/chrome/global/brand.dtd. r=mconley

Backed out changeset dcd8ba6a9028 (bug 1429394) for build bustages. CLOSED TREE Log of the failure: https://treeherder.mozilla.org/logviewer.html#?job_id=171328993&repo=mozilla-inbound&lineNumber=27372 Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/469b253318c17722f4e543cca7580887fb0087eb Push that failed: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=dcd8ba6a9028da11cdcc6f1b9894551dbbc5172a&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified

Manish, it looks like you need to remove https://searchfox.org/mozilla-central/source/toolkit/locales/jar.mn#28 as well. Could you also do that ? Sorry for the trouble :(

please review

Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2ad47d44c723 Remove toolkit/locales/generic/chrome/global/brand.dtd. r=mconley