Closed
Bug 1432229
Opened 7 years ago
Closed 7 years ago
Land compare-locales 2.7 in mozilla-central
Categories
(Core :: Internationalization, defect, P3)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
mozilla60
People
(Reporter: Pike, Assigned: Pike)
References
Details
Attachments
(1 file)
(deleted),
text/x-review-board-request
|
zbraniecki
:
review+
lizzard
:
approval-mozilla-beta+
|
Details |
Once we have the new version of compare-locales, we'll need to land that and python-fluent 0.6 in-tree to be used by bug 1424682.
Heads up, we'd like to uplift this to 59 for cross-channel support.
Updated•7 years ago
|
Priority: -- → P3
Assignee | ||
Comment 1•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7689b34d68c2f4188fd3dbf9f63ecbd4c35ba621&selectedJob=160912351 is on its way through try.
It'd be nice to get some feedback on how that tree's doing with migrations etc.
Comment 2•7 years ago
|
||
> Tt'd be nice to get some feedback on how that tree's doing with migrations etc.
Tested the patch against migrations from bug 1424682 and it all works flawlessly.
Comment hidden (mozreview-request) |
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8949229 [details]
bug 1432229, land compare-locales 2.7 and python-fluent 0.6.2,
https://reviewboard.mozilla.org/r/218602/#review224410
lgtm!
Attachment #8949229 -
Flags: review?(gandalf) → review+
Updated•7 years ago
|
Assignee: nobody → l10n
Comment hidden (mozreview-request) |
Assignee | ||
Comment 6•7 years ago
|
||
In the testing of python-fluent on our existing fluent projects, we discovered a bug that's fixed in fluent 0.6.2.
This passed on try in https://treeherder.mozilla.org/#/jobs?repo=try&revision=ec03ed3651e261e62a75cbf904a8ff293c8c8cd3.
Pushed by axel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b6604798c16d
land compare-locales 2.7 and python-fluent 0.6.2, r=gandalf
Comment 8•7 years ago
|
||
We'll want to request beta uplift for the following three bugs: bug 1426054, bug 1432229 and bug 1436790.
Reason: all three bugs are required to bring the updated version of new localization API (Fluent) to 0.6. Since we're using cross-channel for localization we'd like to start serializing our l10n to use 0.6 syntax in the localization tool (Pontoon).
Once we do, we'll need the updated parser in 59 to be able to read the output.
I'll request uplift for each patch separately, but placing them on the release mgmt radar together.
tracking-firefox59:
--- → ?
Sure, I'll track these for now, and please ask for beta uplift when you are ready.
Comment 10•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
Assignee | ||
Comment 11•7 years ago
|
||
Comment on attachment 8949229 [details]
bug 1432229, land compare-locales 2.7 and python-fluent 0.6.2,
Approval Request Comment
[Feature/Bug causing the regression]: none
[User impact if declined]: we won't be able to take string updates for l10n
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: no dependencies, but this blocks uplifts in bugs 1426054, 1436790
[Is the change risky?]: no
[Why is the change risky/not risky?]: Build-time only, and the code has already been tested to successfully read all our strings as part of a test install of transvision
[String changes made/needed]:
Attachment #8949229 -
Flags: approval-mozilla-beta?
Comment on attachment 8949229 [details]
bug 1432229, land compare-locales 2.7 and python-fluent 0.6.2,
Should land for the 59 beta 10 build.
This looks like fun.
Attachment #8949229 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 13•7 years ago
|
||
bugherder uplift |
You need to log in
before you can comment on or make changes to this bug.
Description
•