Closed Bug 1435266 Opened 7 years ago Closed 7 years ago

Enable index masking by default

Categories

(Core :: JavaScript Engine: JIT, defect, P1)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla60
Tracking Flags:
Tracking Status
firefox59 --- fixed
firefox60 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Patch
(deleted), patch
luke
: review+
RyanVM
: approval-mozilla-beta+
Details | Diff | Splinter Review
We should probably flip the pref after we fix bug 1435209. The plan is to uplift this to 59.
Depends on: 1435209
status-firefox60: --- → affected
Priority: -- → P1
Attached patch Patch (deleted) — — Splinter Review
Attachment #8948972 - Flags: review?(luke)
Comment on attachment 8948972 [details] [diff] [review] Patch Review of attachment 8948972 [details] [diff] [review]: ----------------------------------------------------------------- Great job on all this hard work to get here!
Attachment #8948972 - Flags: review?(luke) → review+
Pushed by jandemooij@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f9def4d47aa3 Enable Spectre index masking by default. r=luke
Perf sheriffs: we expect a Talos regression on Kraken from this. That's a regression we will have to take to mitigate Spectre.
https://hg.mozilla.org/mozilla-central/rev/f9def4d47aa3
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox60: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla60
(In reply to Jan de Mooij [:jandem] from comment #4) > Perf sheriffs: we expect a Talos regression on Kraken from this. That's a > regression we will have to take to mitigate Spectre. Thanks for the heads up! This is one of the alerts: == Change summary for alert #11420 (as of Wed, 07 Feb 2018 14:59:37 GMT) == Regressions: 10% kraken linux64 pgo e10s 792.28 -> 867.58 For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=11420
Blocks: 1433041
Comment on attachment 8948972 [details] [diff] [review] Patch See bug 1431173 comment 6.
Attachment #8948972 - Flags: approval-mozilla-beta?
Comment on attachment 8948972 [details] [diff] [review] Patch Spectre-related fix. Taking for 59b8.
Attachment #8948972 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: