We shouldn't linkify comment links the same way we do normal links. The way we currently do it has side effects: hitting the database unnecessarily, showing tooltips which aren't always relevant, and styling the link to match the bug, not the comment (strikethrough and italics).

fix and some nearby case cleanup

value_quote() added

This one caught me off guard as I misread it many times as you were changing bug links. Does this patch stop the database access for pure comment links only, or bug/comment combination links as well? I would expect the latter to access the database.

I looked again, it seems like it does stop it. I don't see that as a good thing. Combo links probably aren't common enough to worry about perf anyway. I've filed bug #143529 on a longer term way of dealing with comment and combo links.

Bug #146752 I mean.

I thought about proposing an alternative patch to break up the bug/comment links, but thought this was enough for now. I'm not opposed to hitting the database for comments if we can do something useful, like you suggest in bug 146752, but we really shouldn't be using GetBugLink() on it. We should probably either create a GetCommentLink(), and call each as appropriate, or roll them both into one, and pass some kind of flag. There was also some other cleanup in these routines that I wanted to look at once this stuff gets fixed.

Right, isn't it doing something useful now for combo links?

Last I remember, this did everything useful that the old method did, i.e. linking, without the negative consequences. It's pretty simple. :) Is there another issue, other than bug 146752, that I am not seeing?

As far as I can tell, combo links used to have a tooltip like bug links, and this patch removes that.

Comment on attachment 83076 [details] [diff] [review] oops This has now bitrotted, since I've rewritten that section. However, I'm not sure what this is doing - I want |bug 1 comment 3| to be tooltipped just like |bug 1| is.

Unloved bugs targetted for 2.18 but untouched since 9-15-2003 are being retargeted to 2.20 If you plan to act on one immediately, go ahead and pull it back to 2.18.

This bug has not been touched by its owner in over six months, even though it is targeted to 2.20, for which the freeze is 10 days away. Unsetting the target milestone, on the assumption that nobody is actually working on it or has any plans to soon. If you are the owner, and you plan to work on the bug, please give it a real target milestone. If you are the owner, and you do *not* plan to work on it, please reassign it to nobody@bugzilla.org or a .bugs component owner. If you are *anybody*, and you get this comment, and *you* plan to work on the bug, please reassign it to yourself if you have the ability.

I plan to fix this after bug 115796 is committed. I'm planning on using one function to linkify both bugs and comments with the comment parameter triggering the type of link.

It really makes sense to have tooltips for references to other bugs. So there is no reason to remove this feature.