Closed Bug 1437833 Opened 7 years ago Closed 7 years ago

Migration fails when localized file content only changes Terms

Categories

(L20n :: Python Library, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: flod, Assigned: Pike)

References

Details

Attachments

(1 file)

(deleted), text/x-github-pull-request
zbraniecki
: review+
Details
Migration is currently not working for bug 1432338. From my tests, we exit here https://github.com/projectfluent/python-fluent/blob/babad8480a37ae30e80b5900cd76501fcefe5c2f/fluent/migrate/context.py#L358 I think that's because the resulting translated file is identical to English. If I change one string in the Italian file, the migration works as expected. This affects branding patches, but also en-GB as a locale. A workaround is to temporarily remove that check, but I'm not sure if there are other consequences. P.S. 'changeset' is misspelled in that comment
Note: there should likely be a warning in the console. Run without output: Running migration bug_1432338_sync_brand for it INFO:migrate:Localization file browser/browser/branding/sync-brand.ftl does not exist and it will be created Run with output: Running migration bug_1432338_sync_brand for it INFO:migrate:Localization file browser/browser/branding/sync-brand.ftl does not exist and it will be created Writing to /Users/flodolo/mozilla/mercurial/l10n_clones/locales/it/browser/browser/branding/sync-brand.ftl Committing changeset: Bug 1424683 - Introduce sync-brand.ftl, part 1. I think I did a dry-run for bug 1424683, but didn't realize nothing was migrated in the first case.
I know what's going on, taking.
Assignee: nobody → l10n
Attached file link to PR (deleted) —
Flagged you on gh as well. We'll likely want a dot release of python-fluent, and then carry that to m-c.
Attachment #8950564 - Flags: review?(gandalf)
Summary: Migration fails when localized file content is identical to reference content → Migration fails when localized file content only changes Terms
Comment on attachment 8950564 [details] link to PR lgtm! Thanks Axel!
Attachment #8950564 - Flags: review?(gandalf) → review+
The fix has landed and was released with python-fluent 0.6.3. It'll be deployed in m-c in bug 1437950
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: