Closed Bug 1439837 Opened 7 years ago Closed 7 years ago

::-moz-math-anonymous should probably not be accessible to content.

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla60
Tracking Flags:
Tracking Status
firefox60 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

(Keywords: dev-doc-complete)

Attachments

(3 files)

Bug 1439837: Hide ::-moz-math-anonymous from content.
(deleted), text/x-review-board-request
xidorn
: review+
Details
0001-Bug-1439837-Hide-moz-math-anonymous-from-content.-r-.patch
(deleted), patch
xidorn
: review+
Details | Diff | Splinter Review
Fix logic to disable pseudo-elements.
(deleted), patch
xidorn
: review+
Details | Diff | Splinter Review
No description provided.
Comment on attachment 8952650 [details] Bug 1439837: Hide ::-moz-math-anonymous from content. https://reviewboard.mozilla.org/r/221902/#review227764 ::: commit-message-f1fe9:3 (Diff revision 1) > +It's unclear why it's not an anon box, or why is it needed, fwiw, since we never > +style them. It seems to me we can just move it to anonymous box, given that it's not used for style at all, simply for giving something style context. That is basically the same for things like `::-moz-text` etc.
Attachment #8952650 - Flags: review?(xidorn+moz)
Sorry for the splinter attachment, but MozReview wasn't on the mood, apparently.
Assignee: nobody → emilio
Attachment #8952650 - Attachment is obsolete: true
Attachment #8952668 - Flags: review?(xidorn+moz)
Comment on attachment 8952668 [details] [diff] [review] 0001-Bug-1439837-Hide-moz-math-anonymous-from-content.-r-.patch Review of attachment 8952668 [details] [diff] [review]: ----------------------------------------------------------------- Please remember to send an intent to unship for this.
Attachment #8952668 - Flags: review?(xidorn+moz) → review+
Comment on attachment 8952650 [details] Bug 1439837: Hide ::-moz-math-anonymous from content. Actually we need to do go with this one, since the current additional style context code is setup so that it assumes they're pseudo-elements. I'll try to get rid of this pseudo entirely though.
Attachment #8952650 - Flags: review?(xidorn+moz)
Attachment #8952650 - Attachment is obsolete: false
We'll check the docs just in case, when this is resolved.
Keywords: dev-doc-needed
Comment on attachment 8952650 [details] Bug 1439837: Hide ::-moz-math-anonymous from content. https://reviewboard.mozilla.org/r/221902/#review227792 ::: layout/style/nsCSSPseudoElementList.h:59 (Diff revision 1) > -CSS_PSEUDO_ELEMENT(mozMathAnonymous, ":-moz-math-anonymous", 0) > +// FIXME(emilio): It's unclear why this isn't an anon box... Or why it exists at > +// all, since we don't style them. It seems it's clear why it's not an anon box now... Probably leave some comment here to explain the current situation.
Attachment #8952650 - Flags: review?(xidorn+moz) → review+
Without this the test fails on the old style system.
Attachment #8952800 - Flags: review?(xidorn+moz)
[ Triage 2018/02/21: P3 ]
Priority: -- → P3
Attachment #8952800 - Flags: review?(xidorn+moz) → review+
Pushed by ecoal95@gmail.com: https://hg.mozilla.org/integration/autoland/rev/e688c3a1939d Fix logic to disable pseudo-elements. r=xidorn https://hg.mozilla.org/integration/autoland/rev/6b8016311fcc Hide ::-moz-math-anonymous from content. r=xidorn https://hg.mozilla.org/integration/autoland/rev/a177d975a0bb Regenerate the devtools css database. r=me
OK, docs checked, and there is no mention of this on MDN, just like Tantek said in the original intent to unship thread[0] ;-) So no changes made. [0] https://groups.google.com/forum/#!topic/mozilla.dev.platform/nyPLIPReZRU
Keywords: dev-doc-needed → dev-doc-complete
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: